Editorial: Change ValidateTypedArray to not return the buffer #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syg
approved these changes
Apr 28, 2021
michaelficarra
approved these changes
Apr 28, 2021
syg
added
the
ready to merge
ljharb
force-pushed
the
ValidateTypedArray
branch
from
b083b70 to
f7264bb
Compare
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2355 (comment)
Downstream: No uses of ValidateTypedArray in WebIDL, HTML, Intl.
Note that ValidateIntegerTypedArray also returns the buffer, so you might want that handled similarly.
Also, ValidateAtomicAccess returns a value, but changing it to not return that value would be more disruptive. Perhaps it should change its name to something that emphasizes the value it computes, rather than any validation it does.