-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISO 8601 grammar uses incorrect separating punctuation #2190
Labels
Milestone
Comments
I asked and @bakkot answered:
Based on that, I'd guess |
ptomato
added a commit
that referenced
this issue
Jan 20, 2024
The ISO 8601 grammar should use ::: as it parses strings, not source text. (: is for parsing tokens into parse nodes, and :: is for parsing code points into tokens.) Closes: #2190
Merged
Ms2ger
pushed a commit
that referenced
this issue
Jan 22, 2024
The ISO 8601 grammar should use ::: as it parses strings, not source text. (: is for parsing tokens into parse nodes, and :: is for parsing code points into tokens.) Closes: #2190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The ISO 8601 grammar currently separates nonterminals from their productions with
:
, but that is only appropriate for the ECMAScript syntactic grammar (which has as its terminal symbols "ECMAScript tokens defined by the lexical grammar"). Grammars which have Unicode code points as their terminal symbols use either::
(Lexical and RegExp grammars, which "share some productions") or:::
(Numeric String grammar and URI grammar, both of which incorporate nonterminals from the lexical grammar).I'm not sure what the distinction between
::
vs.:::
is intended to represent, but absent guidance from @tc39/ecma262-editors I have a gut feeling that:::
is slightly more appropriate because both the URI and ISO 8601 grammars relate to external specifications.The text was updated successfully, but these errors were encountered: