Enhance error message when encountering the UISI bug (or bug N..)

[jdauphant]

tchap-web-v4/src/components/views/messages/TchapUnknownBody.tsx

Line 18 in d395c73

_t("Decryption fail: Please open Tchap on an other connected device to allow key sharing.");

This message say that "Decryption fail: Please open Tchap on an other connected device to allow key sharing." but there is also the case when the keys haven't been received from the recipient.

The crypto lib have the good error :

And following error with the same missing key :

I recommand, remove the hack and translate the error message provided by the crypto lib.

[mcalinghee]

After some analysis and this is not as trivial as we could think.

Here are some suggestions on how to implement this translation :
Solution 1 :
do the implementation with patch-package on the module matrix-js-sdk

benefits : easier solution than solution 2, and will take less time to have this in production
drawback : the code on the crypto layer is changing very often (every week) and conflict will happen often when upgrading our codebase

Solution 2 :
do the implementation directly in project : https://github.com/matrix-org/matrix-js-sdk

benefits : this is more accurate and long term solution, should not cause regression
drawback : will take some time to get this done and also the crypto layer might change in the coming weeks/months
=> Issue that we could suggest to element : #357

Solution 3 :
we can only translate static translation (as opposed to parameterized translation) or we could translate the most common errors to start with and add translation when they are coming through support.
benefits : easiest solution as we would have to add to only the translations(only tchap_translations.json) and quickest to implement, easier to maintain also
drawback : we have a lot of translation which are parameterized and they cannot be covered in a generic way with this solution, and not all errors will be translated but we translate this when the english errors will be highlighted through the support channel
=> PR for this solution can be found here : #355

[estellecomment]

EDIT

Todo/ideas :

• this PR in tchap-web https://github.com/tchapgouv/tchap-web-v4/pull/355/files
• make some changes in element-web : Add Translation to DecryptionError in matrix-js-sdk/src/crypto #357 : element has done some work here
• add a link to a specific help page in the error message, for the user to find actions for solving : we cannot integrate url links through translations, also we have now a banner for Decryption Error in : Improve decryption error UI by consolidating error messages and providing instructions when possible matrix-org/matrix-react-sdk#9544

[mcalinghee]

Element is changing the appearance of the Decryption Error : matrix-org/matrix-react-sdk#9544
This should be there in the next release, in the meantime I suggest we try to review this PR as it is to give more clarity on the real source of the error

[odelcroi]

What's been discover impacting our two main use cases, the error is the same : - when user lost its key - when the sender does not send the key (uisi bug) Then we can not differentiate the UX between those two use cases :(

…

On Wed, Jan 4, 2023 at 4:44 PM mcalinghee ***@***.***> wrote: Element is changing the appearance of the Decryption Error : matrix-org/matrix-react-sdk#9544 <matrix-org/matrix-react-sdk#9544> This should be there in the next release, in the meantime I suggest we try to review this PR as it is to give more clarity on the real source of the error — Reply to this email directly, view it on GitHub <#350 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7DRIP5ODY6E2J2CC5K2GDWQWLGRANCNFSM6AAAAAATD4MKPI> . You are receiving this because you were assigned.Message ID: ***@***.***>

[odelcroi]

this issue should be reopen in regards to the new component in 4.2