feat: add support for unicode characters in anchor links #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ## Uh, oh | ||
|
|
||
| There is no section named [Potato](#potato). | ||
|
|
||
| There is an anchor named [Tomato](#tomato). | ||
|
|
||
| ## Header with special char ✨ | ||
| ## Header with special char at end ✨ |
There was a problem hiding this comment.
@dklimpel I see there are quite a few bugs related to this, I have some real world examples you might want to try too - as they actively error for me in 3.12 (from megalinter)
## --docker
[--docker](#--docker)
## Step 7 - Lint & Test
[Step 7 - Lint \& Test](#step-7---lint--test)
## Product Owner / Design Approval
[Product Owner / Design Approval](#product-owner--design-approval)These are as they are created by markdown all in one extension in vscode
There was a problem hiding this comment.
I have this added to the tests. And it works.
There was a problem hiding this comment.
That's great news, so this fix isn't in 3.12 - and just needs merging and releasing?
Do we know when it will be released?
There was a problem hiding this comment.
@tcort any ideas for a timeline?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to check and use unicode characters in anchor links (e.g. german umlauts or emojis)
follow up / improvement of:
fixes:
?fail #360probably fixes:
parts are based on:
also added some tests