-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Uptake Sensor #155
Add Uptake Sensor #155
Conversation
@linglejack06 Could you please put the ToF sensor in the intake io instead of making a new sensor io? This is my personal opinion though, what do you think @jkleiber? |
I agree, let's put it in the Intake IO if possible |
Yeah I'll change that |
This reverts commit f8af247.
@wrob3rts just fyi: if you figure out how to interface with the sensor, this is the relevant PR |
@linglejack06 on Saturday we saw that the Time of Flight sensor was causing weird problems on the kit bot. Apparently other teams have seen it take 30+% more CPU usage when it is in use as well. I think we are going to add a banner sensor or a beam break to the uptake. @PChild probably has more details, but let's create a separate branch for a PR that uses a banner sensor instead and keep this PR in our pocket in case the ToF sensor comes back in scope |
okay ill add that PR shortly. |
We got one of the beam breaks installed today in the shooter deck for indexing, its working well and was drop in replace from the banner sensor. I think we can go ahead and close this PR and just go with #163 |
Closing this one in favor of #163 feel free to re-open if we need this for some reason. |
Summary: add sensor to uptake to prevent intake from running with note already in. This will prevent tech fouls.
Changes:
Resolves #149