Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minio): use minio's official docker image #5

Merged
merged 4 commits into from
Nov 15, 2018

Conversation

duanhongyi
Copy link
Member

  1. support the latest minio
  2. use minio's official docker image

@Cryptophobia
Copy link
Member

Thanks for updating the base image. Let's debate what our stance on using standard base images is a bit before we proceed with changing them everywhere.

Copy link

@till till left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, thanks for sending these PRs!

Small nitpick: I would do the CI stuff in one PR and the rest in another. For the least reason to have the PR for changing the image build successfully.

I am happy with the majority doesn't care and merges this though!

Otherwise: 👍 👍 👍 👍

Makefile Outdated Show resolved Hide resolved
rootfs/Dockerfile Show resolved Hide resolved
rootfs/Dockerfile Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@till
Copy link

till commented Nov 14, 2018

@duanhongyi I have one more thing:
https://github.com/teamhephy/minio#minio-binary-mirror

Can you remove this in the README? Seems no longer applicable thanks to your work! :)

Copy link
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the verbosity of the adduser flags and @till's comments need to be addressed. Otherwise, looks really good. 💯

@duanhongyi
Copy link
Member Author

@duanhongyi I have one more thing:
https://github.com/teamhephy/minio#minio-binary-mirror

Can you remove this in the README? Seems no longer applicable thanks to your work! :)

OK

@duanhongyi
Copy link
Member Author

@duanhongyi I have one more thing:
https://github.com/teamhephy/minio#minio-binary-mirror

Can you remove this in the README? Seems no longer applicable thanks to your work! :)

ok

Copy link
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cryptophobia
Copy link
Member

Another awesome PR @duanhongyi! 🥇 Merging now :octocat: !

@Cryptophobia Cryptophobia merged commit 0e597d3 into teamhephy:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants