-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(minio): use minio's official docker image #5
Conversation
duanhongyi
commented
Nov 12, 2018
- support the latest minio
- use minio's official docker image
Thanks for updating the base image. Let's debate what our stance on using standard base images is a bit before we proceed with changing them everywhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off, thanks for sending these PRs!
Small nitpick: I would do the CI stuff in one PR and the rest in another. For the least reason to have the PR for changing the image build successfully.
I am happy with the majority doesn't care and merges this though!
Otherwise: 👍 👍 👍 👍
@duanhongyi I have one more thing: Can you remove this in the README? Seems no longer applicable thanks to your work! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the verbosity of the adduser
flags and @till's comments need to be addressed. Otherwise, looks really good. 💯
OK |
ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Another awesome PR @duanhongyi! 🥇 Merging now |