-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(postgres): use docker's official postgres:11 image #4
Conversation
@duanhongyi , looks like Travis CI is failing because Docker needs to build image before we run tests. We will need to submit a PR to fix this and rerun our tests: Have you tried running the controller with this new database image? |
Yes, there is no problem with the controller. I'm still doing other tests. First, don't merge. I'll do a system test tomorrow. |
@Cryptophobia make docker-build && make test |
ac413b4
to
b538807
Compare
This PR has been running for two days in our pre-release environment, there are five physical machines in this environment, I think there should be no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@duanhongyi Just one change and a couple of questions.
add the latest Minio support, see this PR. |
Merging now as it all looks resolved. Thank you @duanhongyi . |
This broke some stuff, the image no longer has |
Is ca-certificates necessary? |
It is in #3 – I haven't tested all of the previously supported cloud providers, but I was not able to connect to Digital Ocean Spaces with S3_ENDPOINT without ca-certificates, yes. |
Sorry, I didn't verify this in S3 environment. ca-certificates have been added to postgres: 11-alpine. #5 |
awesome! I will test that next, thank you very much |
The original pg9.4 is too old and needs to maintain an independent boto; so I upgraded to the latest pg11, and all Python dependencies were in the official version.
I have passed tests in swift and minio, and I am trying to build other environments.