Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(postgres): use docker's official postgres:11 image #4

Merged
merged 4 commits into from
Nov 14, 2018

Conversation

duanhongyi
Copy link
Member

@duanhongyi duanhongyi commented Nov 5, 2018

The original pg9.4 is too old and needs to maintain an independent boto; so I upgraded to the latest pg11, and all Python dependencies were in the official version.
I have passed tests in swift and minio, and I am trying to build other environments.

@Cryptophobia
Copy link
Member

@duanhongyi , looks like Travis CI is failing because Docker needs to build image before we run tests. We will need to submit a PR to fix this and rerun our tests:
In travis.yml:
script: make test
should become:
script: make docker-build && make test

Have you tried running the controller with this new database image?

@duanhongyi duanhongyi closed this Nov 5, 2018
@duanhongyi duanhongyi reopened this Nov 5, 2018
@duanhongyi
Copy link
Member Author

@duanhongyi , looks like Travis CI is failing because Docker needs to build image before we run tests. We will need to submit a PR to fix this and rerun our tests:
In travis.yml:
script: make test
should become:
script: make docker-build && make test

Have you tried running the controller with this new database image?

Yes, there is no problem with the controller. I'm still doing other tests. First, don't merge. I'll do a system test tomorrow.

@duanhongyi
Copy link
Member Author

@Cryptophobia
Hi Hi, the test has passed.

make docker-build && make test

@duanhongyi duanhongyi force-pushed the master branch 2 times, most recently from ac413b4 to b538807 Compare November 6, 2018 12:25
@duanhongyi
Copy link
Member Author

This PR has been running for two days in our pre-release environment, there are five physical machines in this environment, I think there should be no problem.

Copy link
Member

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duanhongyi Just one change and a couple of questions.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
rootfs/patcher-script.d/patch_wal_e_s3.py Outdated Show resolved Hide resolved
@duanhongyi
Copy link
Member Author

add the latest Minio support, see this PR.

@Cryptophobia
Copy link
Member

Merging now as it all looks resolved. Thank you @duanhongyi .

@Cryptophobia Cryptophobia merged commit 2e39f6e into teamhephy:master Nov 14, 2018
@yebyen
Copy link

yebyen commented Nov 23, 2018

This broke some stuff, the image no longer has ca-certificates package in it, at least. Also missing wget or curl for debugging purposes...

@duanhongyi
Copy link
Member Author

This broke some stuff, the image no longer has ca-certificates package in it, at least. Also missing wget or curl for debugging purposes...

Is ca-certificates necessary?

@kingdonb
Copy link
Member

It is in #3 – I haven't tested all of the previously supported cloud providers, but I was not able to connect to Digital Ocean Spaces with S3_ENDPOINT without ca-certificates, yes.

@duanhongyi
Copy link
Member Author

@Cryptophobia @yebyen

Sorry, I didn't verify this in S3 environment. ca-certificates have been added to postgres: 11-alpine. #5

@kingdonb
Copy link
Member

awesome! I will test that next, thank you very much

This was referenced Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants