Cp/fix/tr delete with running pr #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ignores all the taskruns attached to pipelinerun which are still running. Behaviour with keep, keep-since, all by default ignores taskruns attached to running pipelinerun. Behaviour if user gives taskrun name to delete will reassure before deleting , if user also specify -f flag then it deletes with a warning msg for each taskrun. this also adds ignore-running-pipelinerun flag. This will help user if they want to delete a taskrun in any case Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
fix taskrun getting deleted of running pipelinerun tektoncd#1736 Fix incomplete TaskRuns being deleted when --ignore-running=true tektoncd#1708 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
|
/lgtm |
|
/lgtm |
|
@rupalibehera: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
vinamra28
approved these changes
Oct 7, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
pradeepitm12
added a commit
that referenced
this pull request
Oct 7, 2022
#1731 | [Piyush Garg] Bump to tektoncd/pipeline 0.36.1 | 2022/10/04-14:21 #1731 | [Piyush Garg] Fix pipeline and triggers version | 2022/10/04-14:21 #1737 | [Colin O'Dell] Fix --ignore-running unexpectedly deleting incomplete TaskRuns | 2022/10/07-14:41 #1737 | [Pradeep Kumar] fix taskrun getting deleted of running pipelinerun | 2022/10/07-14:41 #1737 | [Pradeep Kumar] [cherry-pick] taskrun delete fixes | 2022/10/07-14:41 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Oct 7, 2022
#1731 | [Piyush Garg] Bump to tektoncd/pipeline 0.36.1 | 2022/10/04-14:21 #1731 | [Piyush Garg] Fix pipeline and triggers version | 2022/10/04-14:21 #1737 | [Colin O'Dell] Fix --ignore-running unexpectedly deleting incomplete TaskRuns | 2022/10/07-14:41 #1737 | [Pradeep Kumar] fix taskrun getting deleted of running pipelinerun | 2022/10/07-14:41 #1737 | [Pradeep Kumar] [cherry-pick] taskrun delete fixes | 2022/10/07-14:41 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Oct 7, 2022
#1731 | [Piyush Garg] Bump to tektoncd/pipeline 0.36.1 | 2022/10/04-14:21 #1731 | [Piyush Garg] Fix pipeline and triggers version | 2022/10/04-14:21 #1737 | [Colin O'Dell] Fix --ignore-running unexpectedly deleting incomplete TaskRuns | 2022/10/07-14:41 #1737 | [Pradeep Kumar] fix taskrun getting deleted of running pipelinerun | 2022/10/07-14:41 #1737 | [Pradeep Kumar] [cherry-pick] taskrun delete fixes | 2022/10/07-14:41 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
pradeepitm12
added a commit
that referenced
this pull request
Oct 7, 2022
#1731 | [Piyush Garg] Bump to tektoncd/pipeline 0.36.1 | 2022/10/04-14:21 #1731 | [Piyush Garg] Fix pipeline and triggers version | 2022/10/04-14:21 #1737 | [Colin O'Dell] Fix --ignore-running unexpectedly deleting incomplete TaskRuns | 2022/10/07-14:41 #1737 | [Pradeep Kumar] fix taskrun getting deleted of running pipelinerun | 2022/10/07-14:41 #1737 | [Pradeep Kumar] [cherry-pick] taskrun delete fixes | 2022/10/07-14:41 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes
With this fix
tknignores to delete all the taskrun(s) attached to pipelinerun which arestill
running(without a completion time).Behaviour with
keep, keep-since, allby default ignores taskruns attached to runningpipelinerun.
Behaviour if user gives taskrun name to delete will reassure before deleting, if user
also specify -f flag then it deletes with a warning message for each taskrun.
This also adds
ignore-running-pipelinerunflag will helps user to delete a taskrunattached to a running pipelienrun.