Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor shell completion #229

Merged
merged 3 commits into from
Aug 22, 2019
Merged

Refactor shell completion #229

merged 3 commits into from
Aug 22, 2019

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Aug 21, 2019

Refactor how we do shell completion,

  • Commonise between bash and zsh shell functions so we have less chance to forget one or another,
  • Add utility function with a test for adding cusotm completion to a flag,
  • Add completion on serviceAccount for tkn start

@chmouel
Refactor the completions functions
eedc777 
Make the same function definitions between bash and shell so it would be easier
to maintain than duplicate.

Clean and refactor things around.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel
Add common function to add a completion to a flag
19c7c0d 
And make it covered by test along the way.
Add completion on serviceAccounts

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 21, 2019
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipeline/start.go 97.6% 97.6% 0.0
pkg/flags/flags.go Do not exist 15.0%

@chmouel
Copy link
Member Author

chmouel commented Aug 21, 2019

oh fun :

I0821 19:54:49.908] 2019/08/21 19:54:49 Error listing files: GET https://api.github.com/repos/tektoncd/cli/pulls/229/files?page=1: 403 API rate limit exceeded for 35.184.145.65. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 59m59s]

@chmouel
Fix bash completion
a7f216a 
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipeline/start.go 97.6% 97.6% 0.0
pkg/flags/flags.go Do not exist 15.0%

vdemeester
vdemeester approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2019
@tekton-robot tekton-robot merged commit edcee68 into tektoncd:master Aug 22, 2019
@vdemeester vdemeester added this to the 0.3.0 🐱 milestone Aug 22, 2019
@chmouel chmouel deleted the refactor-completion branch August 22, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@hrishin hrishin Awaiting requested review from hrishin

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
0.3.0 🐱
Development

Successfully merging this pull request may close these issues.
4 participants
@chmouel @tekton-robot @vdemeester @googlebot