Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor shell completion #229

Merged
merged 3 commits into from
Aug 22, 2019
Merged

Refactor shell completion #229

merged 3 commits into from
Aug 22, 2019

Commits on Aug 21, 2019

  1. Refactor the completions functions 

    Make the same function definitions between bash and shell so it would be easier
to maintain than duplicate.

Clean and refactor things around.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
    @chmouel
    chmouel committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    eedc777 View commit details
    Browse the repository at this point in the history

  2. Add common function to add a completion to a flag 

    And make it covered by test along the way.
Add completion on serviceAccounts

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
    @chmouel
    chmouel committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    19c7c0d View commit details
    Browse the repository at this point in the history

  3. Fix bash completion 

    Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
    @chmouel
    chmouel committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    a7f216a View commit details
    Browse the repository at this point in the history