-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Triggers dependency for CLI #792
Conversation
Now that tektoncd/triggers#469 is merged, we can get rid of the temporary replace that used a fork of Triggers Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
I ran
|
By chance are you using go v.1.14? We experienced similar issues when the golang Tasks in the catalog we use for our release pipeline was updated. |
Yes! Using go1.13 seems to have fixed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg, pradeepitm12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Now that tektoncd/triggers#469 is merged, we can get rid
of the temporary replace that used a fork of Triggers
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.