Update pipeline version to 0.11-rc1 #469

dibyom · 2020-03-04T19:28:09Z

Changes

After this change, the minimum k8s version is 1.15
Also stop ignoring .mod files, since some dependencies
use go modules.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

Triggers now requires kubernetes version 1.15 or higher

googlebot · 2020-03-04T19:28:14Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

config/500-webhooks.yaml

dibyom · 2020-03-04T19:31:35Z

config/webhook.yaml

-          configMap:
-            name: config-logging-triggers
+        - name: CONFIG_LOGGING_NAME
+          value: config-logging-triggers


pipelines uses config-logging. Using config-logging-triggers as the default.
(The EL sink uses config-logging...we should change that too)

cmd/webhook/main.go

vdemeester

One comment, otherwise seems ok to me 😉

config/500-webhooks.yaml

cmd/webhook/main.go

config/500-webhooks.yaml

dibyom · 2020-03-05T17:15:58Z

.gitignore

@@ -14,7 +14,7 @@
 *.dll

 # Fortran module files
-*.mod
+# *.mod


While Triggers doesn't use go modules (yet!), some of its dependencies do...

dibyom · 2020-03-05T17:32:54Z

config/500-webhooks.yaml

+    pipeline.tekton.dev/release: devel
+webhooks:
+- admissionReviewVersions:
+  - v1alpha1


Had to change this to v1beta1 for it to deploy to my cluster 🤔

As it turns out its the version of the AdmissionReview object, not the CRD type 🤦‍♂️

- After this change, the minimum k8s version is 1.15 - Also stop ignoring .mod files, since some dependencies use go modules. Co-Authored-by: Vincent Demeester <vdemeest@redhat.com> Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

dibyom · 2020-03-05T21:10:35Z

Tried this out locally and it worked!
@vdemeester I think you need to comment @googlebot I consent. 👼
also, cc @ncskier

vdemeester · 2020-03-06T07:46:17Z

@googlebot I consent.

googlebot · 2020-03-06T16:04:23Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

dibyom · 2020-03-06T16:05:06Z

Manually changed the CLA since googlebot seems to have ignored Vincent's comment above!

vdemeester

/lgtm

wlynch · 2020-03-09T19:43:29Z

/approve

tekton-robot · 2020-03-09T19:43:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [wlynch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Now that tektoncd/triggers#469 is merged, we can get rid of the temporary replace that used a fork of Triggers Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

bobcatfish · 2020-03-13T20:03:01Z

hey hey just tried to use a v1beta1 type with triggers and - not sure if you meant to do this in the scope of this PR or not - but it looks like we need to update the validation to support v1beta1 as well in https://github.com/tektoncd/triggers/blob/master/pkg/apis/triggers/v1alpha1/trigger_template_validation.go#L25 @dibyom

dibyom · 2020-03-13T20:22:04Z

Yup thanks! Opened #481

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2020

googlebot added the cla: no label Mar 4, 2020

tekton-robot requested review from dlorenc and ncskier March 4, 2020 19:28

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 4, 2020

dibyom requested review from vdemeester and removed request for dlorenc March 4, 2020 19:28

dibyom commented Mar 4, 2020

View reviewed changes

dibyom force-pushed the v1beta1-bump branch from df389f8 to e216e4c Compare March 4, 2020 20:09

vdemeester reviewed Mar 5, 2020

View reviewed changes

config/500-webhooks.yaml Outdated Show resolved Hide resolved

cmd/webhook/main.go Outdated Show resolved Hide resolved

config/500-webhooks.yaml Outdated Show resolved Hide resolved

vdemeester mentioned this pull request Mar 5, 2020

Bump to v0.11.0-rc1 🚌 tektoncd/cli#778

Merged

4 tasks

dibyom force-pushed the v1beta1-bump branch 2 times, most recently from c3fd843 to 1b1b6e3 Compare March 5, 2020 16:52

dibyom commented Mar 5, 2020

View reviewed changes

dibyom force-pushed the v1beta1-bump branch from f60e98f to b44da54 Compare March 5, 2020 18:26

Update pipeline version to 0.11-rc1

0c6f6de

- After this change, the minimum k8s version is 1.15 - Also stop ignoring .mod files, since some dependencies use go modules. Co-Authored-by: Vincent Demeester <vdemeest@redhat.com> Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

dibyom force-pushed the v1beta1-bump branch from b44da54 to 0c6f6de Compare March 5, 2020 21:02

dibyom changed the title ~~Bump pipeline to v1beta1 + knative/pkg dependency~~ Update pipeline version to 0.11-rc1 Mar 5, 2020

dibyom marked this pull request as ready for review March 5, 2020 21:08

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2020

dibyom added cla: yes and removed cla: no labels Mar 6, 2020

vdemeester approved these changes Mar 6, 2020

View reviewed changes

tekton-robot assigned vdemeester Mar 6, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020

dibyom requested a review from wlynch March 9, 2020 15:00

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020

tekton-robot merged commit 700e5df into tektoncd:master Mar 9, 2020

dibyom deleted the v1beta1-bump branch March 9, 2020 20:01

dibyom added this to the Triggers v0.4.0 milestone Mar 9, 2020

dibyom mentioned this pull request Mar 10, 2020

Update Triggers dependency for CLI tektoncd/cli#792

Merged

4 tasks

dibyom added a commit to dibyom/cli that referenced this pull request Mar 10, 2020

Update Triggers dependency for CLI

8ec66ae

Now that tektoncd/triggers#469 is merged, we can get rid of the temporary replace that used a fork of Triggers Signed-off-by: Dibyo Mukherjee <dibyo@google.com>

dibyom mentioned this pull request Mar 13, 2020

Support creating v1beta1 Pipeline resources #481

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update pipeline version to 0.11-rc1 #469

Update pipeline version to 0.11-rc1 #469

dibyom commented Mar 4, 2020 •

edited

Loading

googlebot commented Mar 4, 2020

dibyom Mar 4, 2020

vdemeester left a comment

dibyom Mar 5, 2020

dibyom Mar 5, 2020

dibyom Mar 5, 2020

dibyom commented Mar 5, 2020

vdemeester commented Mar 6, 2020

googlebot commented Mar 6, 2020

dibyom commented Mar 6, 2020

vdemeester left a comment

wlynch commented Mar 9, 2020

tekton-robot commented Mar 9, 2020

bobcatfish commented Mar 13, 2020

dibyom commented Mar 13, 2020

Update pipeline version to 0.11-rc1 #469

Update pipeline version to 0.11-rc1 #469

Conversation

dibyom commented Mar 4, 2020 • edited Loading

Changes

Submitter Checklist

Release Notes

googlebot commented Mar 4, 2020

dibyom Mar 4, 2020

Choose a reason for hiding this comment

vdemeester left a comment

Choose a reason for hiding this comment

dibyom Mar 5, 2020

Choose a reason for hiding this comment

dibyom Mar 5, 2020

Choose a reason for hiding this comment

dibyom Mar 5, 2020

Choose a reason for hiding this comment

dibyom commented Mar 5, 2020

vdemeester commented Mar 6, 2020

googlebot commented Mar 6, 2020

dibyom commented Mar 6, 2020

vdemeester left a comment

Choose a reason for hiding this comment

wlynch commented Mar 9, 2020

tekton-robot commented Mar 9, 2020

bobcatfish commented Mar 13, 2020

dibyom commented Mar 13, 2020

dibyom commented Mar 4, 2020 •

edited

Loading