TEP-0127: Larger Results via Sidecar Logs #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
|
/kind tep |
tekton-robot
added
the
kind/tep
7 tasks
jerop
force-pushed
the
main
branch
2 times, most recently
from
06e6856
to
10431fb
Compare
|
I've read the TEP and this looks very good to me! This is an ongoing problem that our users encounter. We're happy to sign up to test and use this approach. Thank-you @jerop and @chitrangpatel |
jerop
commented
Nov 30, 2022
abayer
reviewed
Nov 30, 2022
jerop
force-pushed
the
main
branch
4 times, most recently
from
1c56f07
to
a8f11c4
Compare
|
/assign |
bobcatfish
reviewed
Nov 30, 2022
tekton-robot
added
the
approved
jerop
force-pushed
the
main
branch
4 times, most recently
from
9c731cb
to
5953ab7
Compare
afrittoli
reviewed
Dec 1, 2022
afrittoli
reviewed
Dec 1, 2022
afrittoli
reviewed
Dec 1, 2022
afrittoli
reviewed
Dec 1, 2022
afrittoli
reviewed
Dec 1, 2022
|
A couple of comments, but nothing blocking. |
Today, `Results` have a size limit of 4KB per `Step` and 12KB per `TaskRun` in the best case - see [issue][4012]. The goal of [TEP-0086][tep-0086] is to support larger `Results` beyond the current size limits. TEP-0086 has many alternatives but no proposal. This TEP is proposes experimenting with one of the alternatives - `Sidecar` logs. This allows us to support larger `Results` that are stored within `TaskRun` CRDs. [4012]: tektoncd/pipeline#4012 [tep-0086]: https://github.com/tektoncd/community/blob/main/teps/0086-changing-the-way-result-parameters-are-stored.md
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, afrittoli, bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today,
Resultshave a size limit of 4KB perStepand 12KB perTaskRunin the best case - see issue.The goal of TEP-0086 is to support larger
Resultsbeyond the current size limits. TEP-0086 has many alternatives but no proposal. This TEP proposes experimenting with one of the alternatives -Sidecarlogs. This allows us to support largerResultsthat are stored withinTaskRunCRDs.Huge shout out to @chitrangpatel for implementing the POC - see the demo 👏
(As discussed in WG meetings, moving over proposal from #745 into a separate TEP so we can mark it as
implementable)