Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0127: Larger results using sidecar logs - feature flags and cluster-roles #5828

Merged
merged 2 commits into from
Dec 6, 2022
Merged

TEP-0127: Larger results using sidecar logs - feature flags and cluster-roles #5828

merged 2 commits into from
Dec 6, 2022

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Dec 2, 2022 •
edited by jerop
Loading

Changes

Prior to this, we were extracting results from tasks via the termination messages which had a limit of only 4 KB per pod. If users had multiple results outputted by a task then they would have to share the 4KB limit.

We now run a dedicated sidecar that has access to the results of all the steps. This sidecar prints out the result and its content to stdout. The logs of the sidecar are parsed by the taskrun controller and the results updated instead of termination logs. We enforce an upper limit of 4KB per result (configurable) but there is no overall cumulative limit shared the results (users can have as many 4KB (or as configured) results as they desire).

This PR addresses the installation related changes of TEP-0127 - feature-flags and cluster-roles (see #5695).

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Implemented feature flags to enable larger results using sidecar logs.

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 2, 2022
@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2022
@chitrangpatel chitrangpatel force-pushed the TEP-0127-larger-results-using-sidecar-logs-feature-flags branch from 497249c to 3dfb2a8 Compare December 2, 2022 17:56
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 80.3% 84.8% 4.5

@chitrangpatel chitrangpatel force-pushed the TEP-0127-larger-results-using-sidecar-logs-feature-flags branch from 3dfb2a8 to d7dda5d Compare December 2, 2022 18:03
@chitrangpatel
Copy link
Contributor Author

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Dec 2, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 80.3% 84.8% 4.5

@chitrangpatel chitrangpatel mentioned this pull request Dec 2, 2022
Merged
7 tasks
@chitrangpatel chitrangpatel force-pushed the TEP-0127-larger-results-using-sidecar-logs-feature-flags branch from d7dda5d to b583bbd Compare December 2, 2022 18:18
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 80.3% 84.8% 4.5

jerop
jerop reviewed Dec 2, 2022
View reviewed changes
docs/tasks.md Outdated Show resolved Hide resolved
@chitrangpatel chitrangpatel force-pushed the TEP-0127-larger-results-using-sidecar-logs-feature-flags branch from b583bbd to bcd63f7 Compare December 2, 2022 19:00
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 80.3% 84.8% 4.5

@chitrangpatel chitrangpatel changed the title TEP-0127: Larger results using sidecar logs - feature flags TEP-0127: Larger results using sidecar logs - feature flags and cluster-roles Dec 2, 2022
@chitrangpatel
Copy link
Contributor Author

/retest

@chitrangpatel chitrangpatel mentioned this pull request Dec 5, 2022
Merged
7 tasks
@chitrangpatel chitrangpatel force-pushed the TEP-0127-larger-results-using-sidecar-logs-feature-flags branch from bcd63f7 to ef4b817 Compare December 5, 2022 21:24
jerop
jerop reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chitrangpatel thank you for splitting up the PR!

docs/install.md Show resolved Hide resolved
docs/install.md Show resolved Hide resolved
pkg/apis/config/feature_flags_test.go Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 80.3% 84.8% 4.5

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 80.3% 84.8% 4.5

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@abayer
Copy link
Contributor

abayer commented Dec 6, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@tekton-robot tekton-robot merged commit d53dc1b into tektoncd:main Dec 6, 2022
@chitrangpatel chitrangpatel mentioned this pull request Dec 6, 2022
Merged
7 tasks
@chitrangpatel chitrangpatel mentioned this pull request Dec 7, 2022
Merged
7 tasks
This was referenced Dec 7, 2022
Merged
Closed
JeromeJu
JeromeJu reviewed Jan 11, 2023
View reviewed changes
pkg/apis/config/feature_flags_test.go
{
expectedConfig: &config.FeatureFlags{
EnableAPIFields: "stable",
EmbeddedStatus: "full",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason that this is full embedded status here instead of the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeJu JeromeJu JeromeJu left review comments

@jerop jerop jerop approved these changes

@afrittoli afrittoli afrittoli left review comments

@abayer abayer Awaiting requested review from abayer

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@abayer abayer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chitrangpatel @tekton-robot @abayer @afrittoli @jerop @JeromeJu