Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0127: Larger Results via Sidecar Logs - Cleanup #5843

Merged
merged 1 commit into from
Dec 8, 2022
Merged

TEP-0127: Larger Results via Sidecar Logs - Cleanup #5843

merged 1 commit into from
Dec 8, 2022

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Dec 7, 2022 •
edited by jerop
Loading

Changes

This PR addresses some changes in #5828.

Moved config to enable access to sidecar logs into a different folder so that it is not installed by default. Also removed docs for installation (will be added in the final PR) so that it does not suggest that the feature is ready for use.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Moved config to enable access to sidecar logs into a different folder.

/kind feature

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 7, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 7, 2022
@chitrangpatel
Copy link
Contributor Author

@afrittoli this PR addresses your comments in #5828. I hope I haven't missed anything 😄

@chitrangpatel chitrangpatel force-pushed the TEP-0127-larger-results-using-sidecar-logs-feature-flags branch from 1837c82 to a13d996 Compare December 7, 2022 16:02
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2022
@chitrangpatel
TEP 0127 larger results using sidecar logs: Feature flags
ba3337a 
Moved config to enable access to sidecar logs into a different folder so that it is not installed by default. Also addressed some nit comments and removed docs for installation (will be added in the final PR) so that it does not suggest that the feature is ready for use.
@chitrangpatel chitrangpatel force-pushed the TEP-0127-larger-results-using-sidecar-logs-feature-flags branch from a13d996 to ba3337a Compare December 7, 2022 16:05
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2022
@jerop jerop changed the title TEP 0127 larger results using sidecar logs: Feature flags TEP-0127: Larger Results via Sidecar Logs - Feature flags Dec 7, 2022
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@Yongxuanzhang
Copy link
Member

sorry I don't understand the relationship between PR title Larger Results via Sidecar Logs - Feature flags and the changes. It looks like we mainly remove the installation docs and move config files (roles related config). Why the PR naming is feature flags?

@chitrangpatel
Copy link
Contributor Author

it's trying to address comments that were left after the feature flags PR was merged.I could rename it a bit to reflect that this is a bit of a cleanup to the merged PR.

@Yongxuanzhang
Copy link
Member

Yongxuanzhang commented Dec 7, 2022 •
edited
Loading

it's trying to address comments that were left after the feature flags PR was merged.I could rename it a bit to reflect that this is a bit of a cleanup to the merged PR.

I think rename it would be better.
btw this PR is labeled as feature yet it looks more like a cleanup

@chitrangpatel chitrangpatel changed the title TEP-0127: Larger Results via Sidecar Logs - Feature flags TEP-0127: Larger Results via Sidecar Logs - Cleanup Dec 7, 2022
@chitrangpatel
Copy link
Contributor Author

it's trying to address comments that were left after the feature flags PR was merged.I could rename it a bit to reflect that this is a bit of a cleanup to the merged PR.

I think rename it would be better. btw this PR is labeled as feature yet it looks more like a cleanup

Done

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop jerop mentioned this pull request Dec 8, 2022
Closed
7 tasks
@jerop jerop added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Dec 8, 2022
@jerop
Copy link
Member

jerop commented Dec 8, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2022
@chitrangpatel
Copy link
Contributor Author

/retest

@chitrangpatel
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot merged commit 3cc0be1 into tektoncd:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@jerop jerop jerop approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chitrangpatel @Yongxuanzhang @tekton-robot @jerop