Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0121: Adds a new field Retries for TaskRun #5842

Merged
merged 1 commit into from
Dec 8, 2022
Merged

TEP-0121: Adds a new field Retries for TaskRun #5842

merged 1 commit into from
Dec 8, 2022

Conversation

XinruZhang
Copy link
Member

@XinruZhang XinruZhang commented Dec 7, 2022 •
edited
Loading

Changes

This PR adds a new field Retries for v1 and v1beta1 TaskRun, which enables TaskRun reconciler implements the Retries independently from PipelineRun reconciler.

This PR also adds a new member function IsRetriable for TaskRun to indicate whether taskRun.Retries has been exhausted or not.

issue: #5756

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

API change: new `Retries` field in `v1beta1.TaskRun` and `v1.TaskRun`.

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2022
@XinruZhang
Copy link
Member Author

This PR is the first peice of #5842 adding API changes, will open another PR for adding the reconciler logic. We targeting at getting both in before cutting the release.

@XinruZhang
Copy link
Member Author

/assign @jerop
/assign @vdemeester

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_types.go 76.9% 77.4% 0.4
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.2% 92.3% 0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.2% 78.6% 0.4

@XinruZhang XinruZhang mentioned this pull request Dec 7, 2022
Merged
7 tasks
@XinruZhang XinruZhang changed the title [TEP-0121] Adds a new field Retries for TaskRun TEP-0121: Adds a new field Retries for TaskRun Dec 7, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_types.go 76.9% 77.4% 0.4
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.2% 92.3% 0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.2% 78.6% 0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_types.go 76.9% 77.4% 0.4
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.2% 92.3% 0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.2% 78.6% 0.4

@jerop jerop added this to the Pipelines v0.43 milestone Dec 7, 2022
jerop
jerop reviewed Dec 7, 2022
View reviewed changes
docs/taskruns.md Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_types.go 76.9% 77.4% 0.4
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.2% 92.3% 0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.2% 78.6% 0.4

jerop
jerop approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @XinruZhang!

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 8, 2022
@XinruZhang
[TEP-0121] Adds a new field Retries for TaskRun
780a4a5 
This commit adds a new field `Retries` for `v1` and `v1beta1` TaskRun,
which enables TaskRun reconciler implements the `Retries` independently
from PipelineRun reconciler.

This commit also adds a new member function `IsRetriable` for TaskRun
to indicate whether `taskrun.retries` has been exhausted or not.
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/taskrun_types.go 76.9% 77.4% 0.4
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.2% 92.3% 0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go 78.2% 78.6% 0.4

@abayer
Copy link
Contributor

abayer commented Dec 8, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2022
@tekton-robot tekton-robot merged commit 22d197e into tektoncd:main Dec 8, 2022
This was referenced Dec 15, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@chitrangpatel chitrangpatel chitrangpatel approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vdemeester vdemeester

@abayer abayer

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.43
Development

Successfully merging this pull request may close these issues.
6 participants
@XinruZhang @tekton-robot @abayer @chitrangpatel @jerop @vdemeester