TEP-0121: Implement `Retries` in TaskRun #5807

XinruZhang · 2022-11-29T04:38:38Z

Changes

This PR implements Retries in TaskRun, and removes the logic that PipelineRun controller relies on RetriesStatus to determine the termination of a TaskRun or CustomRun/Run.

Key Changes:

New Retries field in both v1beta1.TaskRun and v1.TaskRun
Archive retry attempt history in RetriesStatus for a failed TaskRun, before sending kubernetes and cloud events before a reconcile loop ends.
Unit Tests to test the TaskRun object changes, especially the changes on status.conditions and status.retriesStatus after being reconciled once (one reconcile loop).
Integration Test still works.

fix #5755
fix #5248
/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

API change: new `Retries` field in `v1beta1.TaskRun` and `v1.TaskRun`.

tekton-robot · 2022-11-29T04:43:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	72.9%	-5.3
pkg/reconciler/events/event.go	93.3%	70.0%	-23.3
pkg/reconciler/pipelinerun/pipelinerun.go	85.6%	85.2%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	95.5%	0.7
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	81.5%	80.2%	-1.3

tekton-robot · 2022-11-29T05:12:40Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	72.9%	-5.3
pkg/reconciler/events/event.go	93.3%	70.0%	-23.3
pkg/reconciler/pipelinerun/pipelinerun.go	85.6%	85.2%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	95.5%	0.7
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	81.5%	80.2%	-1.3

tekton-robot · 2022-11-29T14:52:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	72.9%	-5.3
pkg/reconciler/events/event.go	93.3%	70.0%	-23.3
pkg/reconciler/pipelinerun/pipelinerun.go	85.6%	85.2%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	95.5%	0.7
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	81.5%	80.2%	-1.3

XinruZhang · 2022-11-29T15:05:48Z

This is the implementation PR of TEP-0121, see the demo video on a API WG meeting [18:05-21:00].

/assign @pritidesai

cc @tektoncd/core-maintainers
cc @lbernick @JeromeJu because this PR includes V1 API changes.

JeromeJu · 2022-11-29T15:13:01Z

Thanks @XinruZhang and thanks for making the comprehensive changes for the respective conversions.

And this PR lgtm

JeromeJu

The api changes LGTM

pkg/apis/pipeline/v1/taskrun_types.go

lbernick

Closes #5248

@XinruZhang could you test the behavior of your PR against #4071 (comment)?

pkg/reconciler/pipelinerun/pipelinerun_test.go

pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go

pkg/apis/pipeline/v1/taskrun_types.go

tekton-robot · 2022-11-29T15:51:33Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	72.9%	-5.3
pkg/reconciler/events/event.go	93.3%	70.0%	-23.3
pkg/reconciler/pipelinerun/pipelinerun.go	85.6%	85.2%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	95.5%	0.7
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	81.5%	80.2%	-1.3

tekton-robot · 2022-11-29T18:19:45Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	72.9%	-5.3
pkg/reconciler/events/event.go	93.3%	70.0%	-23.3
pkg/reconciler/pipelinerun/pipelinerun.go	85.6%	85.2%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	94.9%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	81.5%	80.2%	-1.3

XinruZhang · 2022-11-29T18:22:39Z

Closes #5248

@XinruZhang could you test the behavior of your PR against #4071 (comment)?

Yes it works as expected:

TaskRun hi retries once, and fails on TimeOut on the second attempt.
TaskRun bye succeeds.
PipelineRun fails on TimedOut.

apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  name: please-say-bye-again-gpgb4-hi
  namespace: default
spec:
  retries: 2
  serviceAccountName: default
  status: TaskRunCancelled
  statusMessage: TaskRun cancelled as the PipelineRun it belongs to has timed out.
  taskSpec:
    steps:
    - image: alpine:3.12
      name: hi
      resources: {}
      script: |
        echo 'hi'
        sleep 10
        exit 1
  timeout: 1h0m0s
status:
  completionTime: "2022-11-29T16:39:07Z"
  conditions:
  - lastTransitionTime: "2022-11-29T16:39:07Z"
    message: TaskRun "please-say-bye-again-gpgb4-hi" was cancelled. TaskRun cancelled
      as the PipelineRun it belongs to has timed out.
    reason: TaskRunCancelled
    status: "False"
    type: Succeeded
  retriesStatus:
    conditions:
      message: |
        "step-hi" exited with code 1 (image: "docker.io/library/alpine@sha256:c75ac27b49326926b803b9ed43bf088bc220d22556de1bc5f72d742c91398f69"); for logs run: kubectl -n default logs please-say-bye-again-gpgb4-hi-pod -c step-hi
      reason: Failed
      status: "False"
      type: Succeeded

apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  name: please-say-bye-again-gpgb4-bye
  namespace: default
spec:
  resources: {}
  serviceAccountName: default
  taskSpec:
    steps:
    - image: alpine:3.12
      name: bye
      resources: {}
      script: |
        echo 'bye'
  timeout: 1h0m0s
status:
  conditions:
  - lastTransitionTime: "2022-11-29T16:39:12Z"
    message: All Steps have completed executing
    reason: Succeeded
    status: "True"
    type: Succeeded

apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  name: please-say-bye-again-gpgb4
  namespace: default
spec:
  pipelineRef:
    name: please-say-bye-again
  serviceAccountName: default
  timeouts:
    pipeline: 1m0s
    tasks: 19s
status:
  completionTime: "2022-11-29T16:39:12Z"
  conditions:
  - lastTransitionTime: "2022-11-29T16:39:12Z"
    message: 'Tasks Completed: 2 (Failed: 1, Cancelled 0), Skipped: 0'
    reason: Failed
    status: "False"
    type: Succeeded
  finallyStartTime: "2022-11-29T16:39:07Z"
  pipelineSpec:
    finally:
    - name: bye
      taskSpec:
        metadata: {}
        spec: null
        steps:
        - image: alpine:3.12
          name: bye
          resources: {}
          script: |
            echo 'bye'
    tasks:
    - name: hi
      retries: 2
      taskSpec:
        metadata: {}
        spec: null
        steps:
        - image: alpine:3.12
          name: hi
          resources: {}
          script: |
            echo 'hi'
            sleep 10
            exit 1
  startTime: "2022-11-29T16:38:48Z"
  taskRuns:
    please-say-bye-again-gpgb4-bye:
      pipelineTaskName: bye
      status:
        completionTime: "2022-11-29T16:39:12Z"
        conditions:
        - lastTransitionTime: "2022-11-29T16:39:12Z"
          message: All Steps have completed executing
          reason: Succeeded
          status: "True"
          type: Succeeded
        podName: please-say-bye-again-gpgb4-bye-pod
        startTime: "2022-11-29T16:39:07Z"
    please-say-bye-again-gpgb4-hi:
      pipelineTaskName: hi
      status:
        completionTime: "2022-11-29T16:39:07Z"
        conditions:
        - lastTransitionTime: "2022-11-29T16:39:07Z"
          message: TaskRun "please-say-bye-again-gpgb4-hi" was cancelled. TaskRun
            cancelled as the PipelineRun it belongs to has timed out.
          reason: TaskRunCancelled
          status: "False"
          type: Succeeded
        podName: please-say-bye-again-gpgb4-hi-pod-retry1
        retriesStatus:
        - completionTime: "2022-11-29T16:39:03Z"
          conditions:
          - lastTransitionTime: "2022-11-29T16:39:03Z"
            message: |
              "step-hi" exited with code 1 (image: "docker.io/library/alpine@sha256:c75ac27b49326926b803b9ed43bf088bc220d22556de1bc5f72d742c91398f69"); for logs run: kubectl -n default logs please-say-bye-again-gpgb4-hi-pod -c step-hi
            reason: Failed
            status: "False"
            type: Succeeded

tekton-robot · 2022-11-29T18:51:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	72.9%	-5.3
pkg/reconciler/events/event.go	93.3%	70.0%	-23.3
pkg/reconciler/pipelinerun/pipelinerun.go	85.6%	85.2%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	94.9%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	81.5%	80.2%	-1.3

XinruZhang · 2022-11-29T18:54:46Z

/retest

docs/taskruns.md

jerop

Thank you @XinruZhang!

docs/taskruns.md

pkg/apis/pipeline/v1beta1/taskrun_types.go

pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go

pkg/reconciler/taskrun/taskrun.go

tekton-robot · 2022-11-30T13:42:11Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	93.9%	94.0%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	76.8%	-1.4
pkg/reconciler/events/event.go	93.3%	70.0%	-23.3
pkg/reconciler/pipelinerun/pipelinerun.go	85.6%	85.2%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	94.9%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	81.5%	80.2%	-1.3

pkg/apis/pipeline/v1/taskrun_types.go

pkg/apis/pipeline/v1beta1/swagger.json

docs/taskruns.md

tekton-robot · 2022-12-01T15:43:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	92.2%	92.3%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	76.8%	-1.4
pkg/reconciler/events/event.go	93.3%	70.0%	-23.3
pkg/reconciler/pipelinerun/pipelinerun.go	85.6%	85.2%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	94.9%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	81.5%	80.2%	-1.3

XinruZhang · 2022-12-01T19:42:19Z

/hold

One thing we haven't fully investigated is Transient Errors. We wouldn't want to retry a TaskRun when transient errors detected. For example: waiting for the remote resource to be ready, waiting for volumes to be mounted. Thanks @pritidesai for pointing this out!

XinruZhang · 2022-12-01T21:08:08Z

/unhold

TL;DR: We do NOT and should NOT mark the resource as False for transient errors.

The current behavior

The transient errors in taskrun implementation: once tr.IsDone() is true, the controller stops reconciling:

pipeline/pkg/reconciler/taskrun/taskrun.go

Line 127 in 8c59d00

if tr.IsDone() {

And if the TaskRun failed to retrieve the remote Task, the taskRun marks the resource as Ongoing:

pipeline/pkg/reconciler/taskrun/taskrun.go

Line 336 in 8c59d00

tr.Status.MarkResourceOngoing(v1beta1.TaskRunReasonResolvingTaskRef, message)

For reference, in PipelineRun, it marks the PipelineRun status as Running when there's remote resource to be resolved, it's worth mentioning that PipelineRun controller tries to resolve those resources on each reconcile loop:

pipeline/pkg/reconciler/pipelinerun/pipelinerun.go

Lines 526 to 535 in 8c59d00

    
           pipelineRunState, err := c.resolvePipelineState(ctx, tasks, pipelineMeta.ObjectMeta, pr, providedResources) 
        
           switch { 
        
           case errors.Is(err, remote.ErrorRequestInProgress): 
        
           	message := fmt.Sprintf("PipelineRun %s/%s awaiting remote resource", pr.Namespace, pr.Name) 
        
           	pr.Status.MarkRunning(v1beta1.TaskRunReasonResolvingTaskRef, message) 
        
           	return nil 
        
           case err != nil: 
        
           	return err 
        
           default: 
        
           }

That's said, we won't mark the resource as Done (Succeeded=False) for transient errors.

tekton-robot · 2022-12-01T21:19:10Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	92.2%	92.3%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	76.8%	-1.4
pkg/reconciler/events/event.go	93.3%	70.0%	-23.3
pkg/reconciler/pipelinerun/pipelinerun.go	85.6%	85.2%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	94.9%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	81.5%	80.1%	-1.4

tekton-robot · 2022-12-01T21:32:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	92.2%	92.3%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	76.8%	-1.4
pkg/reconciler/events/event.go	93.3%	70.0%	-23.3
pkg/reconciler/pipelinerun/pipelinerun.go	85.6%	85.2%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	94.9%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	81.5%	80.2%	-1.3

tekton-robot · 2022-12-01T21:49:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	92.2%	92.3%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	76.8%	-1.4
pkg/reconciler/events/event.go	93.3%	92.5%	-0.8
pkg/reconciler/pipelinerun/pipelinerun.go	85.6%	85.2%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	94.9%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	81.5%	80.2%	-1.3

tekton-robot · 2022-12-06T14:50:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	92.2%	92.3%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	76.8%	-1.4
pkg/reconciler/pipelinerun/pipelinerun.go	86.2%	85.8%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	94.9%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	82.1%	80.7%	-1.4

jerop · 2022-12-06T14:51:08Z

pkg/reconciler/events/k8sevent/event.go

 )

-// EmitK8sEvents emits kubernetes events for object
+// WhenConditionChange emits kubernetes events for object


Suggested change

// WhenConditionChange emits kubernetes events for object

// EmitK8sEventsWhenConditionChange emits kubernetes events for object

jerop · 2022-12-06T14:53:46Z

pkg/apis/pipeline/v1beta1/taskrun_types.go

+// IsRetriable returns true if the TaskRun's Retries is not exhausted.
+func (tr *TaskRun) IsRetriable() bool {
+	return len(tr.Status.RetriesStatus) < tr.Spec.Retries
+}
+


please add unit tests for this function

also, should this function also be added to taskrun_types.go in v1?

jerop · 2022-12-06T14:57:25Z

pkg/apis/pipeline/v1beta1/taskrun_conversion.go

@@ -85,6 +85,7 @@ func (trs *TaskRunSpec) ConvertTo(ctx context.Context, sink *v1.TaskRunSpec) err
 	}
 	sink.Status = v1.TaskRunSpecStatus(trs.Status)
 	sink.StatusMessage = v1.TaskRunSpecStatusMessage(trs.StatusMessage)
+	sink.Retries = trs.Retries


please add retries field to the ConvertTo tests in https://github.com/tektoncd/pipeline/blob/main/pkg/apis/pipeline/v1beta1/taskrun_conversion_test.go

jerop · 2022-12-06T14:57:34Z

pkg/apis/pipeline/v1beta1/taskrun_conversion.go

@@ -164,6 +165,7 @@ func (trs *TaskRunSpec) ConvertFrom(ctx context.Context, source *v1.TaskRunSpec)
 	}
 	trs.Status = TaskRunSpecStatus(source.Status)
 	trs.StatusMessage = TaskRunSpecStatusMessage(source.StatusMessage)
+	trs.Retries = source.Retries


please add retries field to the ConvertFrom tests in https://github.com/tektoncd/pipeline/blob/main/pkg/apis/pipeline/v1beta1/taskrun_conversion_test.go

XinruZhang · 2022-12-06T15:23:56Z

Thanks @jerop! We've discussed offline, will break this PR into smaller pieces, and targeting to get all sub PRs merged before v0.43.0. Thanks!

Keeping this PR open as a reference.

This commit implements `Retries` in `TaskRun`, and removes the logic that PipelineRun controller relies on `RetriesStatus` to determine the termination of a TaskRun or CustomRun/Run. Key Changes: - New `Retries` field in both `v1beta1.TaskRun` and `v1.TaskRun` - Archive retry attempt history in `RetriesStatus` for a failed `TaskRun`, before sending kubernetes and cloud events before a reconcile loop ends. - Unit Tests to test the `TaskRun` object changes, especially the changes on `status.conditions` and `status.retriesStatus` after being reconciled once (one reconcile loop).

tekton-robot · 2022-12-06T15:30:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/taskrun_conversion.go	92.2%	92.3%	0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go	78.2%	76.8%	-1.4
pkg/reconciler/pipelinerun/pipelinerun.go	86.2%	85.8%	-0.4
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.7%	94.9%	0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go	97.9%	97.7%	-0.2
pkg/reconciler/taskrun/taskrun.go	82.1%	80.7%	-1.4

jerop · 2022-12-06T16:03:44Z

Thank you for breaking it down @XinruZhang!

/hold

tekton-robot · 2022-12-08T16:27:45Z

@XinruZhang: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

XinruZhang · 2022-12-15T13:08:50Z

Closing this PR because it is separeted into two sub prs: #5842 and #5844

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 29, 2022

tekton-robot requested review from afrittoli and lbernick November 29, 2022 04:38

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 29, 2022

XinruZhang force-pushed the TEP-0121-Implementation branch from 2e4a97b to 1d1beaf Compare November 29, 2022 05:07

XinruZhang force-pushed the TEP-0121-Implementation branch from 1d1beaf to 819e26e Compare November 29, 2022 14:46

tekton-robot assigned pritidesai Nov 29, 2022

JeromeJu approved these changes Nov 29, 2022

View reviewed changes

JeromeJu reviewed Nov 29, 2022

View reviewed changes

pkg/apis/pipeline/v1/taskrun_types.go Outdated Show resolved Hide resolved

XinruZhang force-pushed the TEP-0121-Implementation branch from 819e26e to 741c534 Compare November 29, 2022 15:46

lbernick reviewed Nov 29, 2022

View reviewed changes

pkg/reconciler/pipelinerun/pipelinerun_test.go Outdated Show resolved Hide resolved

pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1/taskrun_types.go Outdated Show resolved Hide resolved

jerop added this to the Pipelines v0.43 milestone Nov 29, 2022

XinruZhang force-pushed the TEP-0121-Implementation branch from 741c534 to 57ef9ee Compare November 29, 2022 18:15

XinruZhang force-pushed the TEP-0121-Implementation branch from 57ef9ee to 5def3f7 Compare November 29, 2022 18:47

vdemeester reviewed Nov 30, 2022

View reviewed changes

docs/taskruns.md Outdated Show resolved Hide resolved

jerop reviewed Nov 30, 2022

View reviewed changes

XinruZhang force-pushed the TEP-0121-Implementation branch from 5def3f7 to 415cccc Compare November 30, 2022 13:37

bendory reviewed Nov 30, 2022

View reviewed changes

pkg/apis/pipeline/v1/taskrun_types.go Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1beta1/swagger.json Outdated Show resolved Hide resolved

docs/taskruns.md Outdated Show resolved Hide resolved

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2022

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2022

XinruZhang force-pushed the TEP-0121-Implementation branch from 9826aa2 to 448265d Compare December 1, 2022 21:14

XinruZhang force-pushed the TEP-0121-Implementation branch from 448265d to 9826aa2 Compare December 1, 2022 21:26

XinruZhang force-pushed the TEP-0121-Implementation branch from 9826aa2 to e5d7c5d Compare December 1, 2022 21:43

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2022

XinruZhang force-pushed the TEP-0121-Implementation branch from e5d7c5d to 8b295db Compare December 6, 2022 14:44

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2022

jerop reviewed Dec 6, 2022

View reviewed changes

XinruZhang force-pushed the TEP-0121-Implementation branch from 8b295db to 146213e Compare December 6, 2022 15:24

tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 6, 2022

XinruZhang closed this Dec 15, 2022

lbernick mentioned this pull request Jan 18, 2023

task time exceeded timeouts.tasks when task retried #4071

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEP-0121: Implement `Retries` in TaskRun #5807

TEP-0121: Implement `Retries` in TaskRun #5807

XinruZhang commented Nov 29, 2022 •

edited

Loading

tekton-robot commented Nov 29, 2022

tekton-robot commented Nov 29, 2022

tekton-robot commented Nov 29, 2022

XinruZhang commented Nov 29, 2022

JeromeJu commented Nov 29, 2022 •

edited

Loading

JeromeJu left a comment

lbernick left a comment

tekton-robot commented Nov 29, 2022

tekton-robot commented Nov 29, 2022

XinruZhang commented Nov 29, 2022 •

edited

Loading

tekton-robot commented Nov 29, 2022

XinruZhang commented Nov 29, 2022

jerop left a comment

tekton-robot commented Nov 30, 2022

tekton-robot commented Dec 1, 2022

XinruZhang commented Dec 1, 2022

XinruZhang commented Dec 1, 2022 •

edited

Loading

tekton-robot commented Dec 1, 2022

tekton-robot commented Dec 1, 2022

tekton-robot commented Dec 1, 2022

tekton-robot commented Dec 6, 2022

jerop Dec 6, 2022

jerop Dec 6, 2022

jerop Dec 6, 2022

jerop Dec 6, 2022

jerop Dec 6, 2022

XinruZhang commented Dec 6, 2022 •

edited

Loading

tekton-robot commented Dec 6, 2022

jerop commented Dec 6, 2022

tekton-robot commented Dec 8, 2022

XinruZhang commented Dec 15, 2022

	// WhenConditionChange emits kubernetes events for object
	// EmitK8sEventsWhenConditionChange emits kubernetes events for object

TEP-0121: Implement Retries in TaskRun #5807

TEP-0121: Implement Retries in TaskRun #5807

Conversation

XinruZhang commented Nov 29, 2022 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Nov 29, 2022

tekton-robot commented Nov 29, 2022

tekton-robot commented Nov 29, 2022

XinruZhang commented Nov 29, 2022

JeromeJu commented Nov 29, 2022 • edited Loading

JeromeJu left a comment

Choose a reason for hiding this comment

lbernick left a comment

Choose a reason for hiding this comment

tekton-robot commented Nov 29, 2022

tekton-robot commented Nov 29, 2022

XinruZhang commented Nov 29, 2022 • edited Loading

tekton-robot commented Nov 29, 2022

XinruZhang commented Nov 29, 2022

jerop left a comment

Choose a reason for hiding this comment

tekton-robot commented Nov 30, 2022

tekton-robot commented Dec 1, 2022

XinruZhang commented Dec 1, 2022

XinruZhang commented Dec 1, 2022 • edited Loading

The current behavior

tekton-robot commented Dec 1, 2022

tekton-robot commented Dec 1, 2022

tekton-robot commented Dec 1, 2022

tekton-robot commented Dec 6, 2022

jerop Dec 6, 2022

Choose a reason for hiding this comment

jerop Dec 6, 2022

Choose a reason for hiding this comment

jerop Dec 6, 2022

Choose a reason for hiding this comment

jerop Dec 6, 2022

Choose a reason for hiding this comment

jerop Dec 6, 2022

Choose a reason for hiding this comment

XinruZhang commented Dec 6, 2022 • edited Loading

tekton-robot commented Dec 6, 2022

jerop commented Dec 6, 2022

tekton-robot commented Dec 8, 2022

XinruZhang commented Dec 15, 2022

TEP-0121: Implement `Retries` in TaskRun #5807

TEP-0121: Implement `Retries` in TaskRun #5807

XinruZhang commented Nov 29, 2022 •

edited

Loading

JeromeJu commented Nov 29, 2022 •

edited

Loading

XinruZhang commented Nov 29, 2022 •

edited

Loading

XinruZhang commented Dec 1, 2022 •

edited

Loading

XinruZhang commented Dec 6, 2022 •

edited

Loading