Update React Query #2514
Merged
Update React Query #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
tekton-robot
added
lgtm
React Query v4 switches to a new package name, so `react-query` is now `@tanstack/react-query`. Breaking changes: - all query keys must be arrays, so for example `'properties'` is now `['properties']` - query data is read-only in the response from `useQuery` - disabled queries are 'loading' by default, need to switch to `isInitialLoading` flag to prevent blocking page in loading state in case of disabled queries, e.g. Pipeline resource on PipelineRun page when using an inline Pipeline spec as we never need to request a Pipeline resource in that case - `setLogger` removed, logger is now set as a property when defining the QueryClient - `undefined` is no longer a valid value for the data returned for a successful query Package imports and most of the key updates were achieved using the provided codemods. Some manual changes required to address the rest. Tests updated to match including fix for infrequent flake in App.test
AlanGreene
force-pushed
the
react-query
branch
from
0f6dd01
to
48bdd16
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
React Query v4 switches to a new package name, so
react-queryis now@tanstack/react-query.Breaking changes:
'properties'is now['properties']useQueryisInitialLoadingflag to prevent blocking page in loading state in case of disabled queries, e.g. Pipeline resource on PipelineRun page when using an inline Pipeline spec as we never need to request a Pipeline resource in that casesetLoggerremoved, logger is now set as a property when defining the QueryClientundefinedis no longer a valid value for the data returned for a successful queryPackage imports and most of the key updates were achieved using the provided codemods. Some manual changes required to address the rest.
Tests updated to match including fix for infrequent flake in App.test
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
See the contribution guide
for more details.