Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle to settings UI to opt-in to Pipelines v1 resources #2649

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Jan 4, 2023

Changes

Resolves #2598

Add a toggle to the settings page allowing users to opt-in to requesting and managing v1 versions of the Pipelines CRDs: Pipeline, PipelineRun, Task, and TaskRun. This updates the API endpoints to use the corresponding version.

The toggle is off by default and will be included in the next release. Following that it will be on by default for one release, then removed.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add ability to opt-in to using v1 `Pipeline`, `PipelineRun`, `Task`, and `TaskRun` resources with a compatible Tekton Pipelines release (v0.43.0+). This will be enabled by default in a future release.

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2023
@AlanGreene AlanGreene removed the request for review from skaegi January 4, 2023 11:44
@AlanGreene
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2023
@AlanGreene AlanGreene force-pushed the pipelines_v1 branch 2 times, most recently from 9dbc8de to 1e13699 Compare January 4, 2023 12:09
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2023
@AlanGreene AlanGreene force-pushed the pipelines_v1 branch 2 times, most recently from 5174d55 to 3698d74 Compare January 4, 2023 13:10
Add a toggle to the settings page allowing users to opt-in to requesting
and managing v1 versions of the Pipelines CRDs: `Pipeline`, `PipelineRun`,
`Task`, and `TaskRun`. This updates the API endpoints to use the
corresponding version.

The toggle is off by default and will be included in the next release.
Following that it will be on by default for one release, then removed.
@AlanGreene
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2023
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@tekton-robot tekton-robot merged commit dcd71ba into tektoncd:main Jan 4, 2023
@AlanGreene AlanGreene deleted the pipelines_v1 branch January 4, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 Release Dashboard Support
3 participants