-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1 Release Dashboard Support #2598
Comments
@JeromeJu: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Dashboard will move to requesting v1 Pipeline resources when the minimum supported Pipeline release serves v1 resources, so that's likely another 3 or more releases. When the time comes the actual code change should be relatively small, updating the default version used on requests from Line 107 in 8a6d4f3
v1beta1 .
There may also be some opportunity for cleanup, removing fields that are no longer used, etc. |
I think it may be confusing for users, if they install the latest pipeline and dashboard, convert their resources to v1 and see the v1beta1 resources through the dashboard. Is it possible to customise the behaviour of dashboard based on the version of pipeline installed? |
It's the same process we followed for the move from
Maybe, but it would not be a simple task. The Dashboard currently assumes it's dealing with a single version for any given resource kind, and the APIs would need to be dynamically updated based on additional information from the back end. 2 options I currently see for this:
Both of these would require changes to how the API calls are currently made, delaying them until this additional information is available. Another option that might be a little easier to implement (and give users control), would be to add a toggle on the settings page to enable |
Feature request
V1 CRDs are released in tektoncd/pipeline#5579 and this issue tracks down the according requests for the v1 support in dashboard.
The text was updated successfully, but these errors were encountered: