Reduce permissions required by the Import Resources PipelineRun
#2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
tekton-robot
added
do-not-merge/work-in-progress
AlanGreene
force-pushed
the
import_permissions
branch
from
9b59fad
to
1bdf930
Compare
Update the PipelineRun to work as expected with the latest v1beta1 and v1 PipelineRun resource, the `spec.serviceAccountName` field has been removed. Create a new `tekton-dashboard` namespace that will be the default namespace used for the PipelineRun, and update the tutorial to reference this and create the required RoleBinding.
AlanGreene
force-pushed
the
import_permissions
branch
from
1bdf930
to
ad5260b
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#2839
Update the PipelineRun to work as expected with the latest v1beta1 and v1 PipelineRun resource, the
spec.serviceAccountNamefield has been removed.Create a new
tekton-dashboardnamespace that will be the default namespace used for the PipelineRun, and update the tutorial to reference this and create the required RoleBinding./kind documentation
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes