Add custom DataTableSkeleton component to support display of filters #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/misc
briangleeson
requested changes
Aug 6, 2024
packages/components/src/components/DataTableSkeleton/DataTableSkeleton.jsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/DataTableSkeleton/DataTableSkeleton.jsx
Outdated
Show resolved
Hide resolved
If a consumer of the Table component provides a value for the `filters`
prop, they should reasonably be able to expect that those filters will
be displayed regardless of the loading state of the rest of the table.
Update the loading state to use a custom DataTableSkeleton component
based on the Carbon DataTableSkeleton, but with some minor changes:
- only display the description skeleton if the table uses a description
- remove support for zebra striping as this is not used in the Dashboard
- include support for different row sizes directly in the skeleton component
instead of relying on consumers to provide custom classnames to control this
- if the table has `filters`, render them in the table skeleton toolbar
- ensure the filters are left-aligned, replacing the toolbar button
skeleton which is present by default and right-aligned
AlanGreene
force-pushed
the
table_loading_filters
branch
from
df1a5a8
to
101e03a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If a consumer of the Table component provides a value for the
filtersprop, they should reasonably be able to expect that those filters will be displayed regardless of the loading state of the rest of the table.Update the loading state to use a custom DataTableSkeleton component based on the Carbon DataTableSkeleton, but with some minor changes:
filters, render them in the table skeleton toolbar/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes