Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom DataTableSkeleton component to support display of filters #3533

Merged
merged 1 commit into from
Aug 6, 2024

Commits on Aug 6, 2024

  1. Add custom DataTableSkeleton component to support display of filters

    If a consumer of the Table component provides a value for the `filters`
    prop, they should reasonably be able to expect that those filters will
    be displayed regardless of the loading state of the rest of the table.
    
    Update the loading state to use a custom DataTableSkeleton component
    based on the Carbon DataTableSkeleton, but with some minor changes:
    - only display the description skeleton if the table uses a description
    - remove support for zebra striping as this is not used in the Dashboard
    - include support for different row sizes directly in the skeleton component
      instead of relying on consumers to provide custom classnames to control this
    - if the table has `filters`, render them in the table skeleton toolbar
      - ensure the filters are left-aligned, replacing the toolbar button
        skeleton which is present by default and right-aligned
    AlanGreene committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    101e03a View commit details
    Browse the repository at this point in the history