Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of Tekton Dashboard service url content path #3607

Closed
wants to merge 1 commit into from

Conversation

Romanecek
Copy link

This is a solution proposal for the feature request described in #3606

Thank you for your feedback

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 14, 2024
Copy link

linux-foundation-easycla bot commented Sep 14, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign lyndseybu after the PR has been reviewed.
You can assign the PR to them by writing /assign @lyndseybu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 14, 2024
@tekton-robot
Copy link
Contributor

Hi @Romanecek. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

Thanks for the PR @Romanecek. As mentioned in #3606 (comment) there was actually a bug in the client affecting the external logs API.

The Dashboard client automatically detects its context root and uses this as a prefix for all API requests. However, the external logs were missed so they would always go to the domain root instead.

#3614 addresses this and once merged I'll spin a nightly release so you can verify it resolves your issue.

The fix will be included in v0.51.0 which is due in ~1-2 weeks.

Closing this.

@AlanGreene AlanGreene closed this Sep 16, 2024
@AlanGreene AlanGreene removed the request for review from skaegi September 16, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants