Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing API root for external logs requests #3614

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

AlanGreene
Copy link
Member

Changes

Resolves #3606
Replaces #3607

Somehow the external logs APIs in the client never used the API root when constructing the URL. This means that if the Dashboard is deployed at a non-root path, the requests never made it to the logs proxy.

Update the external logs URL util to include the API root in the same manner as we already do for all other APIs.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Sep 16, 2024
@AlanGreene AlanGreene requested review from LyndseyBu and removed request for skaegi September 16, 2024 11:31
Somehow the external logs APIs in the client never used the API
root when constructing the URL. This means that if the Dashboard
is deployed at a non-root path, the requests never made it to
the logs proxy.

Update the external logs URL util to include the API root in the
same manner as we already do for all other APIs.
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2024
@AlanGreene
Copy link
Member Author

AlanGreene commented Sep 16, 2024

Unrelated to this change, will follow-up separately
/test pull-tekton-dashboard-integration-tests

Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@tekton-robot tekton-robot merged commit 2efc34c into tektoncd:main Sep 16, 2024
7 of 8 checks passed
@AlanGreene AlanGreene deleted the logs-proxy_api-root branch September 16, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration of Tekton Dashboard service url content path
3 participants