Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky e2e test TestTaskRunPipelineRunCancel #511

Closed
shashwathi opened this issue Feb 15, 2019 · 0 comments · Fixed by #516
Closed

Fix flaky e2e test TestTaskRunPipelineRunCancel #511

shashwathi opened this issue Feb 15, 2019 · 0 comments · Fixed by #516
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@shashwathi
Copy link
Contributor

Expected Behavior

TestTaskRunPipelineRunCancel e2e test should not be flaky.

Actual Behavior

TestTaskRunPipelineRunCancel fails lot more often on PR submission
example: https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_build-pipeline/493/pull-knative-build-pipeline-integration-tests/1096429645164711938/

Changes in the PR were adding yaml test so go e2e tests were unaffected so expected them not to fail.

Steps to Reproduce the Problem

  1. Run TestTaskRunPipelineRunCancel multiple times

Additional Info

From the logs it appears that pipeline and taskrun is expected to be in Cancelled state but the taskrun hasn't been cancelled yet. It might be an issue of just waiting for state to transition.
@shashwathi shashwathi mentioned this issue Feb 15, 2019
Merged
@bobcatfish bobcatfish added kind/bug Categorizes issue or PR as related to a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Feb 15, 2019
shashwathi added a commit to shashwathi/build-pipeline that referenced this issue Feb 17, 2019
@shashwathi
Fix go e2e tests
1d04ecd 
- refactor go e2e test TestTaskRunPipelineRunCancel to reduce flakiness.
- refactor yaml e2e test bash script. yaml script checks for both
taskruns, pipelineruns to be in unknown status and then check results.

Fixes tektoncd#511
@shashwathi shashwathi mentioned this issue Feb 17, 2019
Merged
shashwathi added a commit to shashwathi/build-pipeline that referenced this issue Feb 18, 2019
@shashwathi
Fix go e2e tests
c786a07 
- refactor go e2e test TestTaskRunPipelineRunCancel to reduce flakiness.
- refactor yaml e2e test bash script. yaml script checks for both
taskruns, pipelineruns to be in unknown status and then check results.
- taskrun `UpdateStatus` updates subresource status and cancel status
sets the status to empty object sometimes.

Fixes tektoncd#511
knative-prow-robot pushed a commit that referenced this issue Feb 19, 2019
@shashwathi @knative-prow-robot
Fix go e2e tests
7e5bd73 
- refactor go e2e test TestTaskRunPipelineRunCancel to reduce flakiness.
- refactor yaml e2e test bash script. yaml script checks for both
taskruns, pipelineruns to be in unknown status and then check results.
- taskrun `UpdateStatus` updates subresource status and cancel status
sets the status to empty object sometimes.

Fixes #511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky e2e tests shashwathi/build-pipeline
2 participants
@bobcatfish @shashwathi