Fix flaky e2e tests #516
Merged
Fix flaky e2e tests #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shashwathi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
|
/test pull-knative-build-pipeline-integration-tests |
1 similar comment
|
/test pull-knative-build-pipeline-integration-tests |
- refactor go e2e test TestTaskRunPipelineRunCancel to reduce flakiness. - refactor yaml e2e test bash script. yaml script checks for both taskruns, pipelineruns to be in unknown status and then check results. - taskrun `UpdateStatus` updates subresource status and cancel status sets the status to empty object sometimes. Fixes tektoncd#511
shashwathi
force-pushed
the
e2e-flaky-test
branch
from
1d04ecd
to
c786a07
Compare
|
/test pull-knative-build-pipeline-integration-tests |
2 similar comments
|
/test pull-knative-build-pipeline-integration-tests |
|
/test pull-knative-build-pipeline-integration-tests |
|
4 successful e2e test runs. I think the fix is in a good shape 👍 @bobcatfish it would be good get this in before release but not a blocker. |
|
/lgtm |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestTaskRunPipelineRunCancelto reduce flakiness.taskruns, pipelineruns to be in unknown status and then check results.
Fixes #511
i will trigger e2e test couple of times to check whether this change fixes it or not.
cc @bobcatfish