Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor trusted resources test code #5820

Closed
2 tasks
Yongxuanzhang opened this issue Dec 1, 2022 · 8 comments
Closed
2 tasks

Refactor trusted resources test code #5820

Yongxuanzhang opened this issue Dec 1, 2022 · 8 comments
Assignees
@Yongxuanzhang
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@Yongxuanzhang
Copy link
Member

Yongxuanzhang commented Dec 1, 2022 •
edited
Loading

Test helper functions in https://github.com/tektoncd/pipeline/blob/main/test/trustedresources.go should be refactored into files where they are called, this will improved the readability

  1. try to remove the https://github.com/tektoncd/pipeline/blob/main/test/trustedresources.go by adding helper functions to each file
  1. Clean up the test code to meet go style
@Yongxuanzhang
Copy link
Member Author

/assign

@Yongxuanzhang Yongxuanzhang mentioned this issue Dec 1, 2022
Merged
7 tasks
@jerop
Copy link
Member

jerop commented Dec 13, 2022

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 13, 2022
@Yongxuanzhang Yongxuanzhang mentioned this issue Dec 19, 2022
Closed
15 tasks
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Jan 4, 2023
@Yongxuanzhang
refactor trusted resources testing functions
c159041 
This commit fixes tektoncd#5820. It refactors the trusted resouces testing
functions into a testing pkg. This will avoid running unit test on these
functions.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
@Yongxuanzhang Yongxuanzhang mentioned this issue Jan 4, 2023
Closed
7 tasks
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Jan 4, 2023
@Yongxuanzhang
refactor trusted resources testing functions
a2a8d7e 
This commit fixes tektoncd#5820. It refactors the trusted resouces testing
functions into a testing pkg. This will avoid running unit test on these
functions.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
@Yongxuanzhang Yongxuanzhang mentioned this issue Jan 10, 2023
Closed
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 13, 2023
@Yongxuanzhang Yongxuanzhang mentioned this issue Mar 20, 2023
Merged
7 tasks
@Yongxuanzhang
Copy link
Member Author

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 22, 2023
@Yongxuanzhang Yongxuanzhang changed the title Refactor trusted resources test code into a internal pkg Refactor trusted resources test code Mar 22, 2023
@lbernick lbernick mentioned this issue Jun 5, 2023
Merged
7 tasks
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Jun 8, 2023
@Yongxuanzhang
remove GetUnsignedTask helper function and use var in each file
2d59be6 
This commit is part of tektoncd#5820. It removes the GetUnsignedTask helper
function and use a var in each test file instead to improve the
readability for developers.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
@Yongxuanzhang Yongxuanzhang mentioned this issue Jun 8, 2023
Merged
7 tasks
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Jun 8, 2023
@Yongxuanzhang
remove GetUnsignedPipeline helper function and use var in each file
c67b554 
This commit is part of tektoncd#5820. It removes the GetUnsignedPipeline helper function and use a var in each test file instead to improve the readability for developers.

No functional change.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
@Yongxuanzhang Yongxuanzhang mentioned this issue Jun 8, 2023
Merged
7 tasks
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Jun 12, 2023
@Yongxuanzhang
remove GetUnsignedPipeline helper function and use var in each file
641ea09 
This commit is part of tektoncd#5820. It removes the GetUnsignedPipeline helper function and use a var in each test file instead to improve the readability for developers.

No functional change.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Jun 12, 2023
@Yongxuanzhang
remove GetUnsignedTask helper function and use var in each file
bea262b 
This commit is part of tektoncd#5820. It removes the GetUnsignedTask helper
function and use a var in each test file instead to improve the
readability for developers.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
@Yongxuanzhang Yongxuanzhang mentioned this issue Jun 13, 2023
Closed
6 tasks
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Jun 20, 2023
@Yongxuanzhang
remove GetUnsignedTask helper function and use var in each file
9cbd64c 
This commit is part of tektoncd#5820. It removes the GetUnsignedTask helper
function and use a var in each test file instead to improve the
readability for developers.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Jun 20, 2023
@Yongxuanzhang
remove GetUnsignedPipeline helper function and use var in each file
8c0a401 
This commit is part of tektoncd#5820. It removes the GetUnsignedPipeline helper function and use a var in each test file instead to improve the readability for developers.

No functional change.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2023
tekton-robot pushed a commit that referenced this issue Sep 7, 2023
@Yongxuanzhang @tekton-robot
remove GetUnsignedPipeline helper function and use var in each file
4ebd753 
This commit is part of #5820. It removes the GetUnsignedPipeline helper function and use a var in each test file instead to improve the readability for developers.

No functional change.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 6, 2023
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Oct 27, 2023
@Yongxuanzhang
remove GetUnsignedTask helper function and use var in each file
0c456b7 
This commit is part of tektoncd#5820. It removes the GetUnsignedTask helper
function and use a var in each test file instead to improve the
readability for developers.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Oct 27, 2023
@Yongxuanzhang
remove GetUnsignedTask helper function and use var in each file
a1077b8 
This commit is part of tektoncd#5820. It removes the GetUnsignedTask helper
function and use a var in each test file instead to improve the
readability for developers.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
tekton-robot pushed a commit that referenced this issue Oct 30, 2023
@Yongxuanzhang @tekton-robot
remove GetUnsignedTask helper function and use var in each file
dcfabf6 
This commit is part of #5820. It removes the GetUnsignedTask helper
function and use a var in each test file instead to improve the
readability for developers.

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yongxuanzhang Yongxuanzhang

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
Tekton Community Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor trusted resources testing functions Yongxuanzhang/pipeline
3 participants
@jerop @Yongxuanzhang @tekton-robot