[TEP-0091] support remote v1 task verification #6764

Yongxuanzhang · 2023-06-02T16:20:18Z

Changes

This commit adds the support for v1 task verification. Previously we only support v1beta1 verification.

Part of #6729

/kind feature

Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Trusted Resources supports v1 remote tasks verification

tekton-robot · 2023-06-02T16:20:20Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Yongxuanzhang · 2023-06-02T16:24:06Z

pkg/reconciler/taskrun/resources/taskref_test.go

@@ -1016,6 +1039,288 @@ func TestGetTaskFunc_VerifyError(t *testing.T) {
 	}
 }

+func TestGetTaskFunc_V1Task_VerifyNoError(t *testing.T) {


The tests in this PR are all copied from current v1beta1 tasks. I tried to merge them into 1 test but seems not so straightforward. Maybe the easiest way for now is to have separate tests? Any suggestions are welcome

I'm guessing this tests might change a bit once we swap the storage version to v1 - I think it's worth checking them to see if we can merge the tests or at least come up with a few helper methods to reduce the amount of copied code between tests

Yes, I will pair with @JeromeJu on fixing the tests for the swap PR.
I tried to merge the v1 tests into v1beta1 tests but it still requires lots of test code changes. But helper functions may help.

This could be tackled as part of #5820

Yongxuanzhang · 2023-06-02T16:25:07Z

This PR only has 2 lines of code, other code changes are copied tests and helper functions.

tekton-robot · 2023-06-02T16:27:40Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	90.0%	90.1%	0.1

tekton-robot · 2023-06-02T16:29:20Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	90.0%	90.1%	0.1

tekton-robot · 2023-06-02T16:29:58Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	90.0%	90.1%	0.1

chitrangpatel · 2023-06-05T15:52:10Z

/assign

pkg/reconciler/taskrun/resources/taskref.go

pkg/reconciler/taskrun/taskrun_test.go

dibyom · 2023-06-05T17:42:18Z

pkg/reconciler/taskrun/taskrun_test.go

+			},
+		},
+	}
+	tr := parse.MustParseV1beta1TaskRun(t, fmt.Sprintf(`


is there a reason we are using a v1beta1TaskRun and not a v1TaskRun?

yes, for now in

pipeline/test/controller.go

Lines 68 to 71 in 4924b51

type Data struct {

PipelineRuns []*v1beta1.PipelineRun

Pipelines []*v1beta1.Pipeline

TaskRuns []*v1beta1.TaskRun

we only support v1beta1 taskrun. The swap PR will change this to v1

currently in #6444 we are swapping to v1, so maybe we should keep both in either case?

I think this is fine-- a v1beta1 TaskRun can reference a v1 Task, and it looks like this is correctly testing that case and will be swapped to a v1 TaskRun in Jerome's PR. @Yongxuanzhang can you update the existing test class names to indicate that they're resolving a v1beta1 Task? @JeromeJu just make sure your PR doesn't change the test cases referencing a v1beta1 Task, otherwise they will become redundant with this test case.

Thanks @lbernick , I left all v1beta1 verifications as they are in both unit tests and e2e tests, only modifying the apiVersion of the pr/tr referencing the v1beta1 pipeline/task.

tekton-robot · 2023-06-05T18:29:08Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	90.0%	90.1%	0.1

tekton-robot · 2023-06-05T18:32:08Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	90.0%	90.1%	0.1

tekton-robot · 2023-06-05T18:49:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	90.0%	90.1%	0.1

tekton-robot · 2023-06-05T18:53:27Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	90.0%	90.1%	0.1

lbernick · 2023-06-05T20:56:03Z

pkg/reconciler/taskrun/taskrun_test.go

+			},
+		},
+	}
+	tr := parse.MustParseV1beta1TaskRun(t, fmt.Sprintf(`


I think this is fine-- a v1beta1 TaskRun can reference a v1 Task, and it looks like this is correctly testing that case and will be swapped to a v1 TaskRun in Jerome's PR. @Yongxuanzhang can you update the existing test class names to indicate that they're resolving a v1beta1 Task? @JeromeJu just make sure your PR doesn't change the test cases referencing a v1beta1 Task, otherwise they will become redundant with this test case.

lbernick · 2023-06-05T20:57:46Z

pkg/reconciler/taskrun/resources/taskref_test.go

@@ -1016,6 +1039,288 @@ func TestGetTaskFunc_VerifyError(t *testing.T) {
 	}
 }

+func TestGetTaskFunc_V1Task_VerifyNoError(t *testing.T) {


This could be tackled as part of #5820

This commit adds the support for v1 task verification. Previously we only support v1beta1 verificaiton. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

tekton-robot · 2023-06-06T04:22:20Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	89.9%	90.0%	0.1

tekton-robot · 2023-06-06T04:43:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/resources/taskref.go	89.9%	90.0%	0.1

tekton-robot · 2023-06-06T14:43:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Yongxuanzhang · 2023-06-06T14:51:07Z

/retest
flake: #6772
log: https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6764/pull-tekton-pipeline-alpha-integration-tests/1665935985864609792
This happened a lot recently 🤔

chitrangpatel · 2023-06-06T15:25:25Z

/lgtm

tekton-robot requested review from abayer and afrittoli June 2, 2023 16:20

Yongxuanzhang changed the title ~~[TEP-0091]support remote v1 task verification~~ [TEP-0091] support remote v1 task verification Jun 2, 2023

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jun 2, 2023

Yongxuanzhang force-pushed the support-v1-verify branch from 1b586a4 to ea1adbd Compare June 2, 2023 16:22

Yongxuanzhang commented Jun 2, 2023

View reviewed changes

Yongxuanzhang marked this pull request as ready for review June 2, 2023 16:24

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2023

tekton-robot requested a review from dibyom June 2, 2023 16:24

tekton-robot assigned chitrangpatel Jun 5, 2023

jerop self-assigned this Jun 5, 2023

JeromeJu reviewed Jun 5, 2023

View reviewed changes

pkg/reconciler/taskrun/resources/taskref.go Show resolved Hide resolved

Yongxuanzhang requested a review from JeromeJu June 5, 2023 17:19

dibyom reviewed Jun 5, 2023

View reviewed changes

pkg/reconciler/taskrun/taskrun_test.go Outdated Show resolved Hide resolved

dibyom reviewed Jun 5, 2023

View reviewed changes

pkg/reconciler/taskrun/taskrun_test.go Outdated Show resolved Hide resolved

dibyom reviewed Jun 5, 2023

View reviewed changes

Yongxuanzhang force-pushed the support-v1-verify branch from ea1adbd to 8c8bfd6 Compare June 5, 2023 18:24

Yongxuanzhang force-pushed the support-v1-verify branch from 8c8bfd6 to 755d4dd Compare June 5, 2023 18:44

Yongxuanzhang requested a review from dibyom June 5, 2023 18:46

Yongxuanzhang mentioned this pull request Jun 5, 2023

[TEP-0091] support remote v1 pipeline verification #6765

Merged

7 tasks

JeromeJu mentioned this pull request Jun 5, 2023

Change the Storage Version to V1 Types #6444

Merged

7 tasks

lbernick approved these changes Jun 5, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023

[TEP-0091]support remote v1 task verification

3da0f9e

This commit adds the support for v1 task verification. Previously we only support v1beta1 verificaiton. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com

Yongxuanzhang force-pushed the support-v1-verify branch from 755d4dd to 3da0f9e Compare June 6, 2023 04:17

Yongxuanzhang mentioned this pull request Jun 6, 2023

[TEP-0091] Support v1 Tasks&Pipelines for trusted resources #6729

Closed

4 tasks

JeromeJu approved these changes Jun 6, 2023

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023

tekton-robot merged commit ec04eef into tektoncd:main Jun 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TEP-0091] support remote v1 task verification #6764

[TEP-0091] support remote v1 task verification #6764

Yongxuanzhang commented Jun 2, 2023 •

edited

Loading

tekton-robot commented Jun 2, 2023

Yongxuanzhang Jun 2, 2023 •

edited

Loading

dibyom Jun 5, 2023

Yongxuanzhang Jun 5, 2023

lbernick Jun 5, 2023

Yongxuanzhang commented Jun 2, 2023

tekton-robot commented Jun 2, 2023

tekton-robot commented Jun 2, 2023

tekton-robot commented Jun 2, 2023

chitrangpatel commented Jun 5, 2023

dibyom Jun 5, 2023

Yongxuanzhang Jun 5, 2023

JeromeJu Jun 5, 2023 •

edited

Loading

lbernick Jun 5, 2023

JeromeJu Jun 6, 2023

tekton-robot commented Jun 5, 2023

tekton-robot commented Jun 5, 2023

tekton-robot commented Jun 5, 2023

tekton-robot commented Jun 5, 2023

lbernick Jun 5, 2023

lbernick Jun 5, 2023

tekton-robot commented Jun 6, 2023

tekton-robot commented Jun 6, 2023

tekton-robot commented Jun 6, 2023

Yongxuanzhang commented Jun 6, 2023 •

edited

Loading

chitrangpatel commented Jun 6, 2023

	type Data struct {
	PipelineRuns []*v1beta1.PipelineRun
	Pipelines []*v1beta1.Pipeline
	TaskRuns []*v1beta1.TaskRun

[TEP-0091] support remote v1 task verification #6764

[TEP-0091] support remote v1 task verification #6764

Conversation

Yongxuanzhang commented Jun 2, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Jun 2, 2023

Yongxuanzhang Jun 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yongxuanzhang commented Jun 2, 2023

tekton-robot commented Jun 2, 2023

tekton-robot commented Jun 2, 2023

tekton-robot commented Jun 2, 2023

chitrangpatel commented Jun 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JeromeJu Jun 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tekton-robot commented Jun 5, 2023

tekton-robot commented Jun 5, 2023

tekton-robot commented Jun 5, 2023

tekton-robot commented Jun 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tekton-robot commented Jun 6, 2023

tekton-robot commented Jun 6, 2023

tekton-robot commented Jun 6, 2023

Yongxuanzhang commented Jun 6, 2023 • edited Loading

chitrangpatel commented Jun 6, 2023

Yongxuanzhang commented Jun 2, 2023 •

edited

Loading

Yongxuanzhang Jun 2, 2023 •

edited

Loading

JeromeJu Jun 5, 2023 •

edited

Loading

Yongxuanzhang commented Jun 6, 2023 •

edited

Loading