TaskRun/PipelineRuns that are failed on some reasons can't be recored in Metrics

[XinruZhang]

Because recording metrics -- durationAndCountMetrics -- is only called in reconcile(), taskruns that failed/finished before calling reconcile() won't be recorded in metrics.

Expected Behavior

Metrics should take the following TaskRunsinto account

• have preparation error
• are cancelled right after scheduled
• timed out before calling reconcile() (for example, be pending for a long time.)

Similarly to PipelineRuns that failed before calling reconcile() should also be included in metrics.

Actual Behavior

TaskRuns and PipelineRuns that failed before calling reconcile() won't be counted.

Steps to Reproduce the Problem

WIP

[XinruZhang]

It would be great if we have e2e test on metrics to cover the case described in this issue.

[XinruZhang]

#5853 addresses the this issue for TaskRuns.

We need to open another PR to address the same issue in PipelineRun reconciler. But before that happens, we'd like to get test ready as described in #5875.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.