Improve Test Coverage on Metrics for TaskRun and PipelineRun Reconcilers

[XinruZhang]

Context

Today, we record the duration, count the number of finished TaskRuns/PipelineRuns:

• pipeline/pkg/reconciler/pipelinerun/pipelinerun.go

  Line 383 in ed8a2c2

  defer c.durationAndCountMetrics(ctx, pr)

• pipeline/pkg/reconciler/taskrun/taskrun.go

  Line 100 in ed8a2c2

  defer c.durationAndCountMetrics(ctx, tr)

However, we don't have tests in place to ensure the metrics recording captures the correct number. Because of that, we had to solely rely on the understanding of the code itself to debug related issues (#4454, #5866) and made modifications accordingly which is time consuming and not appropriate in long term.

TODO

• Unit Test: to ensure metrics behavior in each reconcile loop work
• Integration Test: submit a TaskRun/PipelineRun that may succeed, or fail on different reasons, ensure the metrics captured the number after the TaskRun/PipelineRun isDone().

Thanks @afrittoli for capturing the TODOs in #5853 (review)
Thanks @JeromeJu for capturing that the issue also exists in #5853 (comment)

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.