Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taskrun counter metrics grow up without failed taskrun #4454

Closed
kubovdm opened this issue Jan 7, 2022 · 4 comments · Fixed by #4469
Closed

taskrun counter metrics grow up without failed taskrun #4454

kubovdm opened this issue Jan 7, 2022 · 4 comments · Fixed by #4469
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@kubovdm
Copy link

kubovdm commented Jan 7, 2022

Expected Behavior

tekton_pipelines_controller_taskrun_count{status="failed"} grow up only if taskrun failed and only increase by 1

Actual Behavior

I have alerts about taskrun failed without failed taskrun and then check counter in prometheus and counter is growing up.

Steps to Reproduce the Problem

Install tekton with helm and setup prometheus.

Additional Info

  • Kubernetes version:

Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.4", GitCommit:"b695d79d4f967c403a96986f1750a35eb75e75f1", GitTreeState:"clean", BuildDate:"2021-11-17T15:48:33Z", GoVersion:"go1.16.10", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"20+", GitVersion:"v1.20.10-gke.1600", GitCommit:"ef8e9f64449d73f9824ff5838cea80e21ec6c127", GitTreeState:"clean", BuildDate:"2021-09-06T09:24:20Z", GoVersion:"go1.15.15b5", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.22) and server (1.20) exceeds the supported minor version skew of +/-1


- Tekton Pipeline version:

**v0.27.1% **


<!-- Any other additional information -->
One more fing. For one minutes counter jumped too mach
1750 @1641551193.666
1764 @1641551223.673
1778 @1641551253.666

and for one taskfail i have grow counter with two
and Sorry for my english
@kubovdm kubovdm added the kind/bug Categorizes issue or PR as related to a bug. label Jan 7, 2022
@jerop
Copy link
Member

jerop commented Jan 7, 2022

thanks for the issue report @kubovdm!

here's a related issue for future reference: #3739

@jerop jerop added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 7, 2022
@wlynch
Copy link
Member

wlynch commented Jan 12, 2022

/assign @chuangw6

@tekton-robot
Copy link
Collaborator

@wlynch: GitHub didn't allow me to assign the following users: chuangw6.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @chuangw6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dibyom
Copy link
Member

dibyom commented Feb 7, 2022

/cc @khrm might be working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants