-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tekton_pipelines_controller_taskrun_count recount bug #4469
Conversation
The following is the coverage report on the affected files.
|
/test pull-tekton-pipeline-alpha-integration-tests |
5d1a0d0
to
123f2ce
Compare
The following is the coverage report on the affected files.
|
/test pull-tekton-pipeline-integration-tests |
123f2ce
to
be07341
Compare
The following is the coverage report on the affected files.
|
be07341
to
9a3aaee
Compare
The following is the coverage report on the affected files.
|
/test pull-tekton-pipeline-integration-tests |
9a3aaee
to
a33e2e6
Compare
The following is the coverage report on the affected files.
|
Added before and after condition check to avoid taskrun metrics recount bug.
a33e2e6
to
73b157a
Compare
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @khrm 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Added before and after condition check to avoid taskrun metrics recount bug.
Fixes #4454
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes