cherry-pick to 0.27.x: Propagate Pipeline name label to PipelineRun #4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
|
/retest |
|
/test tekton-pipeline-unit-tests |
1 similar comment
|
/test tekton-pipeline-unit-tests |
|
/retest |
|
Ahhh thanks for catching that @jerop , I'll do that. |
Currently, a `PipelineRun` started in a `Cancelled` or `Pending` state doesn't receive the `Pipeline` name label. As such, a user cannot find all the `PipelineRuns` related to a given `Pipeline`. This is a challenge for a user searching for associated `PipelineRuns` in `Pending` state in order to start them. In this change, we ensure that the `Pipeline` name label is propagated from the `Pipeline` to the `PipelineRun`. Fixes #3903.
…in 0.27 The pipeline name label propagation change in 2a910a3 was merged after a slight change in the way we construct some publicly exported label constants. Bringing in the change to public constants would have technically been breaking for a patch release. This reintroduces GroupName to the label construction when propagating the pipeline name label to workaround the conflict.
ghost
changed the title
|
@jerop I ended up bringing back the |
vdemeester
approved these changes
Aug 19, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
ping @tektoncd/core-maintainers this is a cherrypick for 0.27, PTAL. |
|
thanks @sbwsg /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cherry-pick #4163 into v0.27.x branch in preparation for a v0.27.2 release on Monday.
The above fixes a bug where Pipelines created in Pending or Cancelled state wouldn't receive a
tekton.dev/pipeline = <pipelineName>label, limiting the ability to filter for them.Another commit was added to resolve a small skew in some publicly exported constants that have changed on
mainafter the v0.27 branch was cut. Bringing the updated label constants over to 0.27 would be, I think, technically a breaking change - if someone were importing pipelines @ 0.27 into their codebase they'd need to update usage of these constants in their own code from one patch release to the next. 🤷 I don't know how likely this really is but I figure it doesn't hurt./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes