Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick to 0.27.x: Propagate Pipeline name label to PipelineRun #4174

Merged
merged 2 commits into from Aug 23, 2021
Merged

cherry-pick to 0.27.x: Propagate Pipeline name label to PipelineRun #4174

merged 2 commits into from Aug 23, 2021

Commits on Aug 19, 2021

  1. Propagate Pipeline name label to PipelineRun 

    Currently, a `PipelineRun` started in a `Cancelled` or `Pending` state
doesn't receive the `Pipeline` name label.

As such, a user cannot find all the `PipelineRuns` related to a given
`Pipeline`. This is a challenge for a user searching for associated
`PipelineRuns` in `Pending` state in order to start them.

In this change, we ensure that the `Pipeline` name label is propagated
from the `Pipeline` to the `PipelineRun`.

Fixes #3903.
    @jerop
    jerop authored and Scott committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    2a910a3 View commit details
    Browse the repository at this point in the history

  2. Patch pipeline name label with GroupName to avoid back compat change … 

    …in 0.27

The pipeline name label propagation change in 2a910a3 was merged after a slight
change in the way we construct some publicly exported label constants. Bringing
in the change to public constants would have technically been breaking for a
patch release.

This reintroduces GroupName to the label construction when propagating the
pipeline name label to workaround the conflict.
    Scott committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    66bacd7 View commit details
    Browse the repository at this point in the history