Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate yaml e2e test from knative/build #493

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Migrate yaml e2e test from knative/build #493

merged 2 commits into from
Feb 15, 2019

Commits on Feb 15, 2019

  1. Migrate yaml e2e test from knative/build 

    Fixes tektoncd#302

what: Add yaml tests which cover different features of knative build in
knative build pipeline like mounting secret as volume, templating
arguements.
list build yamls tests are not added:
- build with `source` key. As build added support for multiple sources
build examples included both `source` and `sources` key version of
build. In taskrun world it means the same thing
(https://github.com/knative/build/tree/master/test/sources)
- build subpath feature is not supported in taskrun
(https://github.com/knative/build/tree/master/test/subpath)
- build with multiple
steps(https://github.com/knative/build/tree/master/test/multiple-steps). taskrun contains examples with multiple
steps
- build that
panics (https://github.com/knative/build/tree/master/test/panic). Taskrun with expectation to fail is not supported
in yaml
- build with
timeout (https://github.com/knative/build/tree/master/test/build-with-timeout). Taskrun with timeout test is already present in
e2e go test
- build with custom source. Taskrun does nto support custom source
(https://github.com/knative/build/tree/master/test/custom-source)
- build that
fails (https://github.com/knative/build/tree/master/test/fail). Taskrun
does not support failed taskruns
- build with step status
(https://github.com/knative/build/tree/master/test/step-status). go e2e
tests already cover this feature
- build yaml tests git-init image directly. This is indirectly testing
git resource and does not add much value.
(https://github.com/knative/build/tree/master/test/reuse-git-init)
    Shash Reddy committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    28a63f9 View commit details
    Browse the repository at this point in the history

  2. Add support for tempalting volume names and volume config names 

    why: Build supported this feature and one of the build yaml test relies on
this feature
what: Taskrun can template volumes names and config volume sources
    Shash Reddy committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    161aa81 View commit details
    Browse the repository at this point in the history