Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resolvers deployment, with release and e2e integration #5395

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Add resolvers deployment, with release and e2e integration #5395

merged 1 commit into from
Aug 31, 2022

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Aug 30, 2022

Changes

Closes #4710

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: The separate Resolutions project has been folded into Pipeline. If currently using Resolution, remove the tekton-remote-resolution namespace before upgrading and installing the new "resolvers.yaml".

@abayer abayer added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 30, 2022
@tekton-robot tekton-robot added the release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. label Aug 30, 2022
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 30, 2022
@abayer
Copy link
Contributor Author

abayer commented Aug 30, 2022

/assign @lbernick @dibyom @jerop @pritidesai @afrittoli @vdemeester

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/hub/resolver.go 70.8% 70.6% -0.2

@abayer abayer force-pushed the resolution-resolvers-deployment branch from 774ac09 to 69073aa Compare August 30, 2022 17:39
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/hub/resolver.go 70.8% 70.6% -0.2

@abayer abayer force-pushed the resolution-resolvers-deployment branch from 69073aa to fcc15e6 Compare August 30, 2022 18:09
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/hub/resolver.go 70.8% 70.6% -0.2

@abayer abayer force-pushed the resolution-resolvers-deployment branch from fcc15e6 to cb5a313 Compare August 30, 2022 18:41
@abayer
Copy link
Contributor Author

abayer commented Aug 30, 2022

...I swear that the tests in test/resolvers_test.go all passed when I initially wrote this commit, but then I screwed myself up by not re-running those tests after incorporating tektoncd/resolution#75. Whoops. =)

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/hub/resolver.go 70.8% 70.6% -0.2

@abayer
Copy link
Contributor Author

abayer commented Aug 30, 2022

/retest

Hrm. The build tests keep failing and I can't figure out why...

@abayer abayer force-pushed the resolution-resolvers-deployment branch from cb5a313 to 7308a1b Compare August 30, 2022 20:10
@abayer
Copy link
Contributor Author

abayer commented Aug 30, 2022

I can't reproduce the pull-tekton-pipeline-build-tests failure locally, and it's not exactly a helpful failure:

./test/presubmit-tests.sh: line 60: 79368 Killed                  KO_DOCKER_REPO=example.com ko resolve --platform=all --push=false -R -f config > /dev/null

...right as it gets to the end of the ko resolve call. For giggles, I've broken up the ko resolve into two calls, one for everything but config/resolvers, and one just for config/resolvers. Maybe that'll help?

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/hub/resolver.go 70.8% 70.6% -0.2

@abayer
Copy link
Contributor Author

abayer commented Aug 30, 2022

/retest

@abayer
Copy link
Contributor Author

abayer commented Aug 30, 2022

/retest

Well, splitting up the ko resolve calls did work. I don't know why, but 🤷. Some flakiness on the e2e tests, but that just came out of nowhere, so I'm retrying...

@abayer
Copy link
Contributor Author

abayer commented Aug 30, 2022

Ok, the failure is legit - see #5396 for details and (hopefully) a solution.

@abayer
Copy link
Contributor Author

abayer commented Aug 31, 2022

/retest

lbernick
lbernick approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@abayer
Add resolvers deployment, with release and e2e integration
e4ae55b 
Closes tektoncd#4710

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer force-pushed the resolution-resolvers-deployment branch from 7308a1b to e4ae55b Compare August 31, 2022 14:52
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resolution/resolver/hub/resolver.go 70.8% 70.6% -0.2

vdemeester
vdemeester approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lbernick,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@tekton-robot tekton-robot merged commit af4d0e6 into tektoncd:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@lbernick lbernick lbernick approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@vdemeester vdemeester

@pritidesai pritidesai

@afrittoli afrittoli

@dibyom dibyom

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promote Remote Resolution to beta
8 participants
@abayer @tekton-robot @vdemeester @lbernick @pritidesai @afrittoli @dibyom @jerop