Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestYamls for change in ko create #5396

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Fix TestYamls for change in ko create #5396

merged 1 commit into from
Aug 31, 2022

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Aug 30, 2022

Changes

With ko-build/ko#750, which we picked up when we bumped ko to v0.12.0 in the test-runner image, -n (namespace) is no longer an argument for ko create. So we need to ensure that the namespace for the TestYamls CRDs is actually set properly, and get rid of the -n (namespace) from our invocation of ko create.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@abayer abayer added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Aug 30, 2022
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2022
@abayer
Copy link
Contributor Author

abayer commented Aug 30, 2022

/assign @imjasonh @afrittoli @vdemeester @lbernick @jerop

@abayer abayer mentioned this pull request Aug 30, 2022
Merged
7 tasks
vdemeester
vdemeester reviewed Aug 30, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using « ko create ... -- --namespace=foo » instead ? I think it is the supported way isn’t it ?

@abayer
Copy link
Contributor Author

abayer commented Aug 30, 2022

Why not using « ko create ... -- --namespace=foo » instead ? I think it is the supported way isn’t it ?

Huh, didn't think of that. Well, let's see if this works anyway? =)

@abayer
Copy link
Contributor Author

abayer commented Aug 30, 2022

Well, that worked, but lemme try the -- -namespace (ns) approach...

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2022
@abayer
Fix TestYamls for change in ko create
df12ce0 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
afrittoli
afrittoli reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afrittoli,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afrittoli
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@tekton-robot tekton-robot merged commit a1ca389 into tektoncd:main Aug 31, 2022
This was referenced Sep 6, 2022
Merged
Merged
Merged
@afrittoli
Copy link
Member

/cherrypick release-v0.36.x

@tekton-robot tekton-robot mentioned this pull request Sep 6, 2022
Closed
@tekton-robot
Copy link
Collaborator

@afrittoli: new pull request created: #5441

In response to this:

/cherrypick release-v0.36.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@vdemeester vdemeester

@imjasonh imjasonh

@afrittoli afrittoli

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abayer @tekton-robot @afrittoli @vdemeester @imjasonh @jerop @lbernick