Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.36.x] Fix TestYamls for change in ko create #5441

Closed
wants to merge 1 commit into from
Closed

[release-v0.36.x] Fix TestYamls for change in ko create #5441

wants to merge 1 commit into from

Conversation

tekton-robot
Copy link
Collaborator

This is an automated cherry-pick of #5396

/assign afrittoli

NONE

@abayer
Fix TestYamls for change in ko create
da3de27 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@tekton-robot tekton-robot mentioned this pull request Sep 6, 2022
Merged
7 tasks
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 6, 2022
@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign afrittoli after the PR has been reviewed.
You can assign the PR to them by writing /assign @afrittoli in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2022
@tekton-robot
Copy link
Collaborator Author

@tekton-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-build-tests da3de27 link true /test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abayer
Copy link
Contributor

abayer commented Sep 6, 2022

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Sep 6, 2022
@abayer
Copy link
Contributor

abayer commented Sep 6, 2022

Replaced by #5445 which contains the //#nosec fix too.

@abayer abayer closed this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli Awaiting requested review from afrittoli

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@afrittoli afrittoli

Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tekton-robot @abayer @afrittoli