TEP-0114: Reconciler, event, config, webhook support for CustomRuns #5662

abayer · 2022-10-19T13:55:13Z

Changes

This adds a reconciler for CustomRuns, and adds support for events and cloud events for CustomRuns as well.

It also adds the actual CRD for CustomRun to config/, along with cluster role changes for CustomRuns, and adds support for CustomRun to the webhook.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Reconciler, event, config, and webhook support for CustomRuns

abayer · 2022-10-19T13:55:21Z

/assign @jerop

tekton-robot · 2022-10-19T14:00:20Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/customrun/controller.go	Do not exist	100.0%
pkg/reconciler/customrun/customrun.go	Do not exist	100.0%
pkg/reconciler/events/cache/cache.go	82.4%	86.4%	4.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go	88.2%	88.4%	0.2
pkg/reconciler/events/cloudevent/cloudevent.go	91.0%	90.1%	-0.9
test/controller.go	19.8%	19.0%	-0.8

tekton-robot · 2022-10-19T16:08:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/customrun/controller.go	Do not exist	100.0%
pkg/reconciler/customrun/customrun.go	Do not exist	100.0%
pkg/reconciler/events/cache/cache.go	82.4%	86.4%	4.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go	88.2%	88.4%	0.2
pkg/reconciler/events/cloudevent/cloudevent.go	91.0%	90.1%	-0.9
test/controller.go	19.8%	19.0%	-0.8

abayer · 2022-10-19T17:29:32Z

/hold

Moving this out of WIP but leaving it on hold until after 0.41.0 releases.

Oh, and I have a work-in-progress on switching pkg/reconciler/pipelinerun/pipelinerun.go to creating v1beta1.CustomRuns instead of v1alpha1.Runs - working on that is what made me realize the work in this PR needed to be done first. =)

/assign @lbernick

pkg/reconciler/customrun/customrun.go

pkg/reconciler/customrun/customrun_test.go

jerop · 2022-10-19T18:22:25Z

thank you @abayer!!

tekton-robot · 2022-10-19T19:54:10Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/customrun/controller.go	Do not exist	100.0%
pkg/reconciler/customrun/customrun.go	Do not exist	100.0%
pkg/reconciler/events/cache/cache.go	82.4%	86.4%	4.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go	88.2%	88.4%	0.2
pkg/reconciler/events/cloudevent/cloudevent.go	91.0%	90.1%	-0.9
test/controller.go	19.8%	19.0%	-0.8

tekton-robot · 2022-10-19T20:04:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/customrun/controller.go	Do not exist	100.0%
pkg/reconciler/customrun/customrun.go	Do not exist	100.0%
pkg/reconciler/events/cache/cache.go	82.4%	86.4%	4.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go	88.2%	88.4%	0.2
pkg/reconciler/events/cloudevent/cloudevent.go	91.0%	90.1%	-0.9
test/controller.go	19.8%	19.0%	-0.8

tekton-robot · 2022-10-19T20:28:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/customrun/controller.go	Do not exist	100.0%
pkg/reconciler/customrun/customrun.go	Do not exist	100.0%
pkg/reconciler/events/cache/cache.go	82.4%	86.4%	4.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go	88.2%	88.4%	0.2
pkg/reconciler/events/cloudevent/cloudevent.go	91.0%	90.8%	-0.3
test/controller.go	19.8%	19.0%	-0.8

config/300-customrun.yaml

lbernick · 2022-10-20T13:18:33Z

pkg/reconciler/customrun/customrun.go

+		// to the custom tasks they control. To avoid sending duplicate events,
+		// CloudEvents for "CustomRuns" are only sent when enabled


out of scope for this PR but this seems like something that would vary between custom tasks, not tekton installations

tekton-robot · 2022-10-20T13:33:40Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/customrun/controller.go	Do not exist	100.0%
pkg/reconciler/customrun/customrun.go	Do not exist	100.0%
pkg/reconciler/events/cache/cache.go	82.4%	86.4%	4.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go	88.2%	88.4%	0.2
pkg/reconciler/events/cloudevent/cloudevent.go	91.0%	90.8%	-0.3
test/controller.go	19.8%	19.0%	-0.8

test/controller.go

pkg/reconciler/customrun/customrun.go

tekton-robot · 2022-10-21T15:34:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/customrun/controller.go	Do not exist	100.0%
pkg/reconciler/customrun/customrun.go	Do not exist	100.0%
pkg/reconciler/events/cache/cache.go	82.4%	86.4%	4.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go	88.2%	88.4%	0.2
pkg/reconciler/events/cloudevent/cloudevent.go	91.0%	90.8%	-0.3
test/controller.go	19.8%	19.0%	-0.8

abayer · 2022-11-01T14:11:37Z

/hold cancel

tekton-robot · 2022-11-01T14:17:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/customrun/controller.go	Do not exist	100.0%
pkg/reconciler/customrun/customrun.go	Do not exist	100.0%
pkg/reconciler/events/cache/cache.go	82.4%	86.4%	4.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go	88.2%	88.4%	0.2
pkg/reconciler/events/cloudevent/cloudevent.go	91.0%	90.8%	-0.3
test/controller.go	19.8%	19.0%	-0.8

tekton-robot · 2022-11-03T15:18:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This adds a reconciler for `CustomRun`s, and adds support for events and cloud events for `CustomRun`s as well. It also adds the actual CRD for `CustomRun` to `config/`, along with cluster role changes for `CustomRun`s, and adds support for `CustomRun` to the webhook. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>

tekton-robot · 2022-11-03T18:43:33Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/customrun/controller.go	Do not exist	100.0%
pkg/reconciler/customrun/customrun.go	Do not exist	100.0%
pkg/reconciler/events/cache/cache.go	82.4%	86.4%	4.0
pkg/reconciler/events/cloudevent/cloud_event_controller.go	88.2%	88.4%	0.2
pkg/reconciler/events/cloudevent/cloudevent.go	91.0%	90.8%	-0.3
test/controller.go	30.4%	29.2%	-1.2

jerop

/lgtm

thank you @abayer!

lbernick · 2022-11-03T19:37:15Z

It looks like this PR removed retries from the spec but not retriesStatus from the status. Was this intentional?

As discussed in [TEP-0114][tep-0114], `retries` and `retriesStatus` will not be included in the initial release of `CustomRuns`. In tektoncd#5662, we removed the `retries` field from the spec. This is a follow up change removing `retriesStatus` field from the status. [tep-0114]: https://github.com/tektoncd/community/blob/main/teps/0114-custom-tasks-beta.md#exclude-retries-and-retriesstatus

abayer · 2022-11-03T19:57:40Z

It looks like this PR removed retries from the spec but not retriesStatus from the status. Was this intentional?

Nope, that was a mistake. I'll open a followup.

abayer · 2022-11-03T19:57:52Z

...or @jerop's already on it. =)

As discussed in [TEP-0114][tep-0114], `retries` and `retriesStatus` will not be included in the initial release of `CustomRuns`. In tektoncd#5662, we removed the `retries` field from the spec. This is a follow up change removing `retriesStatus` field from the status. [tep-0114]: https://github.com/tektoncd/community/blob/main/teps/0114-custom-tasks-beta.md#exclude-retries-and-retriesstatus

jerop · 2022-11-03T20:04:17Z

haha yes, should have commented here first 😁

As discussed in [TEP-0114][tep-0114], `retries` and `retriesStatus` will not be included in the initial release of `CustomRuns`. In tektoncd#5662, we removed the `retries` field from the spec. This is a follow up change removing `retriesStatus` field from the status. [tep-0114]: https://github.com/tektoncd/community/blob/main/teps/0114-custom-tasks-beta.md#exclude-retries-and-retriesstatus

As discussed in [TEP-0114][tep-0114], `retries` and `retriesStatus` will not be included in the initial release of `CustomRuns`. In #5662, we removed the `retries` field from the spec. This is a follow up change removing `retriesStatus` field from the status. [tep-0114]: https://github.com/tektoncd/community/blob/main/teps/0114-custom-tasks-beta.md#exclude-retries-and-retriesstatus

abayer added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 19, 2022

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 19, 2022

tekton-robot requested review from bobcatfish and lbernick October 19, 2022 13:55

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 19, 2022

tekton-robot assigned jerop Oct 19, 2022

abayer force-pushed the reconciler-for-customruns branch from 7ed8a9a to d7e4bb2 Compare October 19, 2022 16:02

abayer changed the title ~~WIP: Reconciler and event support for CustomRuns~~ WIP: Reconciler, event, config, webhook support for CustomRuns Oct 19, 2022

tekton-robot assigned lbernick Oct 19, 2022

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2022

abayer changed the title ~~WIP: Reconciler, event, config, webhook support for CustomRuns~~ Reconciler, event, config, webhook support for CustomRuns Oct 19, 2022

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2022

jerop reviewed Oct 19, 2022

View reviewed changes

jerop added this to the Pipelines v0.42 milestone Oct 19, 2022

abayer force-pushed the reconciler-for-customruns branch from d7e4bb2 to 143f9fd Compare October 19, 2022 19:47

abayer force-pushed the reconciler-for-customruns branch from 143f9fd to 0e25835 Compare October 19, 2022 19:58

abayer force-pushed the reconciler-for-customruns branch from 0e25835 to 6921227 Compare October 19, 2022 20:22

jerop mentioned this pull request Oct 19, 2022

TEP-0114: Custom Tasks Beta - Required Work #4313

Closed

7 tasks

lbernick reviewed Oct 20, 2022

View reviewed changes

abayer force-pushed the reconciler-for-customruns branch from 6921227 to d0d343c Compare October 20, 2022 13:28

XinruZhang reviewed Oct 21, 2022

View reviewed changes

test/controller.go Outdated Show resolved Hide resolved

pkg/reconciler/customrun/customrun.go Outdated Show resolved Hide resolved

abayer force-pushed the reconciler-for-customruns branch from 20eed59 to 61427be Compare October 21, 2022 15:28

XinruZhang mentioned this pull request Oct 24, 2022

TEP-0114: Custom Task Beta - User Guide #5677

Merged

7 tasks

abayer force-pushed the reconciler-for-customruns branch from 61427be to 2f959d9 Compare November 1, 2022 14:11

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2022

abayer mentioned this pull request Nov 1, 2022

TEP-0114: Remove retries field in the initial release. #5694

Closed

6 tasks

vdemeester approved these changes Nov 3, 2022

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022

abayer force-pushed the reconciler-for-customruns branch from 2f959d9 to 375d480 Compare November 3, 2022 18:37

jerop reviewed Nov 3, 2022

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2022

tekton-robot merged commit 14eba83 into tektoncd:main Nov 3, 2022

jerop mentioned this pull request Nov 3, 2022

Add RunReason and CustomRunReason #5718

Merged

3 tasks

jerop mentioned this pull request Nov 3, 2022

Remove retriesStatus from CustomRunStatus #5719

Merged

4 tasks

jerop changed the title ~~Reconciler, event, config, webhook support for CustomRuns~~ TEP-0114: Reconciler, event, config, webhook support for CustomRuns Nov 9, 2022

XinruZhang mentioned this pull request Nov 18, 2022

TEP-0114: Bring Retries and RetriesStatus back #5765

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEP-0114: Reconciler, event, config, webhook support for CustomRuns #5662

TEP-0114: Reconciler, event, config, webhook support for CustomRuns #5662

abayer commented Oct 19, 2022 •

edited

Loading

abayer commented Oct 19, 2022

tekton-robot commented Oct 19, 2022

tekton-robot commented Oct 19, 2022

abayer commented Oct 19, 2022 •

edited

Loading

jerop commented Oct 19, 2022

tekton-robot commented Oct 19, 2022

tekton-robot commented Oct 19, 2022

tekton-robot commented Oct 19, 2022

lbernick Oct 20, 2022

tekton-robot commented Oct 20, 2022

tekton-robot commented Oct 21, 2022

abayer commented Nov 1, 2022

tekton-robot commented Nov 1, 2022

tekton-robot commented Nov 3, 2022

tekton-robot commented Nov 3, 2022

jerop left a comment

lbernick commented Nov 3, 2022

abayer commented Nov 3, 2022

abayer commented Nov 3, 2022

jerop commented Nov 3, 2022

		// to the custom tasks they control. To avoid sending duplicate events,
		// CloudEvents for "CustomRuns" are only sent when enabled

TEP-0114: Reconciler, event, config, webhook support for CustomRuns #5662

TEP-0114: Reconciler, event, config, webhook support for CustomRuns #5662

Conversation

abayer commented Oct 19, 2022 • edited Loading

Changes

Submitter Checklist

Release Notes

abayer commented Oct 19, 2022

tekton-robot commented Oct 19, 2022

tekton-robot commented Oct 19, 2022

abayer commented Oct 19, 2022 • edited Loading

jerop commented Oct 19, 2022

tekton-robot commented Oct 19, 2022

tekton-robot commented Oct 19, 2022

tekton-robot commented Oct 19, 2022

lbernick Oct 20, 2022

Choose a reason for hiding this comment

tekton-robot commented Oct 20, 2022

tekton-robot commented Oct 21, 2022

abayer commented Nov 1, 2022

tekton-robot commented Nov 1, 2022

tekton-robot commented Nov 3, 2022

tekton-robot commented Nov 3, 2022

jerop left a comment

Choose a reason for hiding this comment

lbernick commented Nov 3, 2022

abayer commented Nov 3, 2022

abayer commented Nov 3, 2022

jerop commented Nov 3, 2022

abayer commented Oct 19, 2022 •

edited

Loading

abayer commented Oct 19, 2022 •

edited

Loading