-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RunReason and CustomRunReason #5718
Conversation
The following is the coverage report on the affected files.
|
fwiw, compilation failure can be found at https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/5718/pull-tekton-pipeline-build-tests/1588255157798309888#1:build-log.txt%3A1369-1373 |
Prior to this change, we did not have `RunReason` and `CustomRunReason`. As a result, there were instances where we reused `TaskRunReason` and `PipelineRunReason`. This worked because the underlying strings are the same, but it is confusing when reading the code (and reviewing changes). In this change, we: - introduce `RunReason` and `CustomRunReason` - clean up existing reasons to use the enum - add three common reasons - started, running, successful and failed
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
/lgtm |
events flake /test tekton-pipeline-unit-tests |
Changes
Prior to this change, we did not have
RunReason
andCustomRunReason
. As a result, there were instances where we reusedTaskRunReason
andPipelineRunReason
. This worked because the underlying strings are the same, but it is confusing when reading the code (and reviewing changes).In this change, we:
RunReason
andCustomRunReason
/kind cleanup
Follow up to my comments in #5662 (comment) and #5662 (comment) (cc @abayer)
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes