Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1 clients for examples_test #5799

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Add v1 clients for examples_test #5799

merged 2 commits into from
Nov 28, 2022

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Nov 25, 2022 •
edited
Loading

Changes

This PR contains 2 commits which accomplish the following:

  • Add regarding v1 clients for the prerequisites of the v1-CRD release testing
  • Update example_tests wait status setup for v1-CRD examples tests on Status

Fixes: #5793
/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs included if any changes are user facing
  • [n/a] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 25, 2022
@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@JeromeJu JeromeJu marked this pull request as ready for review November 25, 2022 01:57
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2022
@JeromeJu JeromeJu changed the title Add V1 clients for examples_test Add v1 clients for examples_test Nov 25, 2022
@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 25, 2022
@JeromeJu JeromeJu mentioned this pull request Nov 25, 2022
Merged
6 tasks
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, XinruZhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lbernick
lbernick reviewed Nov 28, 2022
View reviewed changes
test/wait.go Outdated Show resolved Hide resolved
@JeromeJu
Add v1 clients
afc34be 
This commit adds the v1 clients.
@JeromeJu JeromeJu force-pushed the v1-clients branch 2 times, most recently from 888bca2 to 7d3b608 Compare November 28, 2022 19:14
@JeromeJu
Copy link
Member Author

/retest
codebase not updated

@lbernick
Copy link
Member

@JeromeJu what do you mean by "codebase not updated"? Are you experiencing issues with CI not running the latest changes you've pushed? or is the issue that the previous CI run posts a failed status while the newer CI run is still going? If the latter, I think the newer CI run should post its status when it completes, so you shouldn't need to run "retest". (If you do need to run "retest", this is an issue worth looking into.)

@JeromeJu
Copy link
Member Author

/retest

1 similar comment
@JeromeJu
Copy link
Member Author

/retest

@JeromeJu
Copy link
Member Author

JeromeJu commented Nov 28, 2022 •
edited
Loading

Are you experiencing issues with CI not running the latest changes you've pushed

Yes I am experiencing issues with CI not running the latest changes that I've pushed. And for the earlier case I believe I have had to /retest twice.

Previously there was a build test failure but after pushing a fix it sticks around for two CI run results

@JeromeJu JeromeJu force-pushed the v1-clients branch 2 times, most recently from b91bb31 to b5c66ce Compare November 28, 2022 21:21
@JeromeJu JeromeJu removed the request for review from pritidesai November 28, 2022 21:22
@JeromeJu JeromeJu requested review from lbernick and removed request for dibyom and jerop November 28, 2022 21:22
@lbernick lbernick self-assigned this Nov 28, 2022
lbernick
lbernick reviewed Nov 28, 2022
View reviewed changes
test/wait.go Outdated Show resolved Hide resolved
@JeromeJu
Complete examples tests setup
98dbcf5 
This commit adds the version argument to wait status function for the
integration tests setup and completes the examples_tests for v1.
@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@JeromeJu
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit bb3b1ae into tektoncd:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick left review comments

@XinruZhang XinruZhang XinruZhang approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ./test/examples_test.go for V1 CRDS
5 participants
@JeromeJu @tekton-robot @lbernick @vdemeester @XinruZhang