Fix Wrong Condition Reason When Fails to Stop Sidecars for A Finished TaskRun #5901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TaskRun Prior to this commit, if a TaskRun fails to stop sidecars, the failure reason is `TaskRunResolutionFailed` which does not make sense at all. This commit creates a new reason for StopSideCar failure, and fix the wrong condition reason.
tekton-robot
added
kind/cleanup
tekton-robot
added
the
size/XS
|
/test pull-tekton-pipeline-integration-tests Flake: TestExamples/v1beta1/taskruns/dind-sidecar |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a wrong condition reason when fails to stop sidecars for a finished
TaskRun.Prior to this PR, if a TaskRun fails to stop sidecars, the failure reason is
TaskRunResolutionFailedwhich does not make sense at all. This PR creates a new reasonTaskRunReasonStopSidecarFailedfor StopSideCar failure, and fix the wrong condition reason./kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Has Docs included if any changes are user facingHas Tests included if any functionality added or changedfunctionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes