Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google.golang.org/grpc from 1.51.0 to 1.53.0 #6125

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 8, 2023

Bumps google.golang.org/grpc from 1.51.0 to 1.53.0.

Release notes

Sourced from google.golang.org/grpc's releases.

Release 1.53.0

API Changes

  • balancer: support injection of per-call metadata from LB policies (#5853)
  • resolver: remove deprecated field resolver.Target.Endpoint and replace with resolver.Target.Endpoint() (#5852)

New Features

  • xds/ringhash: introduce GRPC_RING_HASH_CAP environment variable to override the maximum ring size. (#5884)
  • rls: propagate headers received in RLS response to backends (#5883)

Bug Fixes

  • transport: drain client transport when streamID approaches MaxStreamID (#5889)
  • server: after GracefulStop, ensure connections are closed when final RPC completes (#5968)
  • server: fix a few issues where grpc server uses RST_STREAM for non-HTTP/2 errors (#5893)
  • xdsclient: fix race which can happen when multiple load reporting calls are made at the same time. (#5927)
  • rls: fix a data race involving the LRU cache (#5925)
  • xds: fix panic involving double close of channel in xDS transport (#5959)
  • gcp/observability: update method name validation (#5951)

Documentation

  • credentials/oauth: mark NewOauthAccess as deprecated (#5882)

Release 1.52.3

Bug Fixes

  • Fix user-agent version

Release 1.52.2

Bug Fixes

  • xds: fix panic involving double close of channel in xDS transport (#5959)

Release 1.52.1

Bug Fixes

  • grpclb: rename grpclbstate package back to state (#5963)

Release 1.52.0

New Features

  • xdsclient: log node ID with verbosity INFO (#5860)
  • ringhash: impose cap on max_ring_size to reduce possibility of OOMs (#5801)

Behavior Changes

... (truncated)

Commits
  • dba26e1 Change version to 1.53.0 (#5983)
  • 2a1e934 server: after GracefulStop, ensure connections are closed when final RPC comp...
  • e2d69aa tests: fix spelling of variable (#5966)
  • a6376c9 xds/resolver: cleanup tests to use real xDS client 3/n (#5953)
  • bf8fc46 xds/resolver: cleanup tests to use real xDS client 5/n (#5955)
  • 3930549 resolver: replace resolver.Target.Endpoint field with Endpoint() method (#5852)
  • 894816c grpclb: rename grpclbstate package back to state (#5962)
  • e5a0237 encoding: fix duplicate compressor names (#5958)
  • 4adb2a7 xds/resolver: cleanup tests to use real xDS client 2/n (#5952)
  • 52a8392 gcp/observability: update method name validation (#5951)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Used by dependabot - identifies all PRs created by dependabot kind/misc Categorizes issue or PR as a miscellaneuous one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. labels Feb 8, 2023
@tekton-robot
Copy link
Collaborator

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 8, 2023
@wlynch
Copy link
Member

wlynch commented Feb 10, 2023

/test tekton-pipeline-unit-tests

@jerop
Copy link
Member

jerop commented Feb 14, 2023

{Failed spire_test.go:436: verify error: unable to dial SPIRE server: failed to build resolver: passthrough: received empty target in Build()} cc @jagathprakash

/test tekton-pipeline-unit-tests

@vdemeester
Copy link
Member

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@jagathprakash
Copy link
Member

@

{Failed spire_test.go:436: verify error: unable to dial SPIRE server: failed to build resolver: passthrough: received empty target in Build()} cc @jagathprakash

/test tekton-pipeline-unit-tests

@lumjjb @pxp928 Here we are creating a fakeSPIRE server and using that to sign/verify etc. Not sure why we cannot dial to this fake server. Any idea what could have gone wrong with the new version of GRPC?

@pxp928
Copy link
Member

pxp928 commented Feb 14, 2023

@

{Failed spire_test.go:436: verify error: unable to dial SPIRE server: failed to build resolver: passthrough: received empty target in Build()} cc @jagathprakash
/test tekton-pipeline-unit-tests

@lumjjb @pxp928 Here we are creating a fakeSPIRE server and using that to sign/verify etc. Not sure why we cannot dial to this fake server. Any idea what could have gone wrong with the new version of GRPC?

I will make a PR to fix this.

@pxp928
Copy link
Member

pxp928 commented Feb 15, 2023

Created the following PR to update the tests -> #6168

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.51.0 to 1.53.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.51.0...v1.53.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/google.golang.org/grpc-1.53.0 branch from 5f4c499 to 7abb27c Compare February 17, 2023 21:03
@tekton-robot
Copy link
Collaborator

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-unit-tests 7abb27c link true /test tekton-pipeline-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 21, 2023

Looks like google.golang.org/grpc is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Feb 21, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/google.golang.org/grpc-1.53.0 branch February 21, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Used by dependabot - identifies all PRs created by dependabot kind/misc Categorizes issue or PR as a miscellaneuous one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants