-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated spire unit test based on grpc update #6168
Conversation
/kind cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @pxp928
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: pxp928 <parth.psu@gmail.com>
ae3cb57
to
82c7ea0
Compare
@pritidesai @jerop Addressed comment and ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
Address the issue where an update from google.golang.org/grpc from 1.51.0 to 1.53.0 causes the spire tests to fail. See PR: #6125
Initially, the spire server was not instantiated because it was not needed for the test. Passing in an empty
sc.config.ServerAddr
did not cause an error but with the grpc update, a check was added for the endpoint and returns an error if empty:https://github.com/grpc/grpc-go/blob/master/internal/resolver/passthrough/passthrough.go#L34-L36
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes