Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated spire unit test based on grpc update #6168

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

pxp928
Copy link
Member

@pxp928 pxp928 commented Feb 14, 2023

Changes

Address the issue where an update from google.golang.org/grpc from 1.51.0 to 1.53.0 causes the spire tests to fail. See PR: #6125

Initially, the spire server was not instantiated because it was not needed for the test. Passing in an empty sc.config.ServerAddr did not cause an error but with the grpc update, a check was added for the endpoint and returns an error if empty:
https://github.com/grpc/grpc-go/blob/master/internal/resolver/passthrough/passthrough.go#L34-L36

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2023
@pxp928
Copy link
Member Author

pxp928 commented Feb 15, 2023

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 15, 2023
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pxp928

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
pkg/spire/spire_test.go Outdated Show resolved Hide resolved
@pritidesai
Copy link
Member

These changes are superset of PR #6125 addressing a broken unit test. We could close the other PR (#6125) once this merged.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023
Signed-off-by: pxp928 <parth.psu@gmail.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@pxp928
Copy link
Member Author

pxp928 commented Feb 21, 2023

@pritidesai @jerop Addressed comment and ready for review

Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@tekton-robot tekton-robot merged commit 21dc1d1 into tektoncd:main Feb 21, 2023
@pxp928 pxp928 deleted the fix-spire-test branch February 21, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants