-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEP0138] Decouple v1beta1 beta feature validation #6941
[TEP0138] Decouple v1beta1 beta feature validation #6941
Conversation
c746eac
to
d1a9bdf
Compare
d1a9bdf
to
fbf7455
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
fbf7455
to
6c5c24e
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/hold |
a88db96
to
a32e4c8
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
a32e4c8
to
7563a5b
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
I've updated the PR and seems all current comments shall be resolved. Shall we merge this cc @afrittoli and @pritidesai ? 🙏 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel, lbernick, Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold want to make sure a non-googler approves as discussed in #7260 (feel free to unhold) |
} | ||
for i, pt := range ps.Finally { | ||
errs = errs.Also(pt.validateBetaFields(ctx).ViaFieldIndex("finally", i)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeromeJu I am sorry to go back on this but we had two new promotions - matrix and task level resources:
https://github.com/tektoncd/pipeline/blob/main/docs/additional-configs.md#beta-features
Do we need them here as well? or I think the features themselves have the check, is that sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this shall be sufficient. Task-level resources beta promotion and Matrix beta promotion shall already have the beta validations covered.
And this function was meant to bring back the validations that were once missing at the stage TEP0138 was not in place and while feature & API versioning were coupled.
thanks @JeromeJu, the changes look good to me, I have left a few minor doc string comments in general and a question on recently promoted features. |
7e07b8a
to
f9f5375
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
This commit decouples the existing beta feature validation in v1beta1. Prior to this change, beta features are regarded as stable in v1beta1 apiVersion and they only require enable-api-fields to be set to beta in v1 apiVersion but not in v1beta1. This PR removes the gap between the validations of the stable features in v1 and v1beta1 by syncing up the validations in v1beta1. Fixes: tektoncd#6592
This commit moves the Task.Validate and Pipeline.Validate back to TaskSpec.Validate and PipelineSpec.Validate. This serves the same purpose of fixing tektoncd#7077. part of: tektoncd#7177 related: TEP0138 /kind misc
f9f5375
to
48b1586
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
Thanks @pritidesai . I've addressed the comments. Please lemme know if there are any other concerns? Or would you mind approving this given the release cutoff dates tmr 🙏 |
thanks @JeromeJu for addressing all the comments 🙏 /lgtm |
is there anything pending here? I think the required dependencies are addressed, please unhold this if there are no additional concerns. |
Thanks for the time reviewing and the instructive comments ! @pritidesai /unhold |
/retest |
Changes
This PR contains 2 commits. The first decouples the existing beta
feature validation in v1beta1. Prior to this change, beta features are
regarded as stable in v1beta1 apiVersion and they are validated only in
v1 api behind beta enable-api-fields but not in v1beta1. This PR removes
the gapbetween the validations of the stable features in v1 and v1beta1.
The second commit moved Task.Validate and Pipeline.Validate to
TaskSpec.Validate and PipelineSpec.Validate.
It also updates the api compatibility policy to clarify that feature
stability levels are independent on CRD apiVersions.
Fixes: #6592
Part of: #7177
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes