Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoting Matrix to Beta 🎉 🎓 #7164

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

pritidesai
Copy link
Member

Changes

Matrix was introduced in Tekton Pipelines 0.38. We have introduced a lot of testing around matrix feature including unit/e2e/integration tests based on the feedback from the users and community. Matrix unblocks variety of use cases migrating from Travis/Jenkins.

This is a very crucial feature for many end-users while allowing to maintain clean, concise, and flexible catalog of pipelines.

Part of #5265 and #6110

We have accomplished most of the checklist except producing task results. The implementation for this feature is nearly done and opening a PR soon.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Matrix feature is promoted to beta and possible to utilize with enable-api-fields set to beta.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2023
@pritidesai
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 29, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 98.8% 98.8% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 98.8% 98.8% -0.0

@JeromeJu
Copy link
Member

JeromeJu commented Oct 2, 2023

Thanks a lot @pritidesai . Excited to have this feature promotion!
/assign
Would we want this to be added to the current milestone?

@jerop jerop added this to the Pipelines v0.53 LTS milestone Oct 2, 2023
@Yongxuanzhang
Copy link
Member

/assign

@JeromeJu
Copy link
Member

JeromeJu commented Oct 2, 2023

/assign @afrittoli @jerop @vdemeester

@jerop
Copy link
Member

jerop commented Oct 5, 2023

'The step "echo" in TaskRun "matrixed-pr-sp4hz-platforms-and-browsers-dag-0"
failed to pull the image "". The pod errored with the message: "Back-off pulling
image "alpine"."'

/test pull-tekton-pipeline-beta-integration-tests

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2023
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2023
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
docs/additional-configs.md Outdated Show resolved Hide resolved
Matrix was introduced in Tekton Pipelines 0.38. We have introduced a lot of
testing around matrix feature including unit/e2e/integration tests.

Matrix unblocks variety of use cases for systems migrating from travis/jenkins.

This is a very crucial feature for many end-users while allowing to maintain
clean, concise, and flexible catalog of pipelines.

Part of tektoncd#5265 and tektoncd#6110

Signed-off-by: Priti Desai <pdesai@us.ibm.com>
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @pritidesai 😻

/lgtm

/test pull-tekton-pipeline-build-tests

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, vdemeester, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Yongxuanzhang,jerop,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop
Copy link
Member

jerop commented Oct 18, 2023

/test pull-tekton-pipeline-build-tests

@tekton-robot tekton-robot merged commit c7de7b1 into tektoncd:main Oct 18, 2023
12 checks passed
@pritidesai pritidesai deleted the matrix-beta branch October 18, 2023 22:03
@jerop jerop linked an issue Oct 18, 2023 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matrix Beta
7 participants