Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triggers release pipeline does not contain core interceptors #1006

Closed
dibyom opened this issue Mar 18, 2021 · 0 comments · Fixed by #1007
Closed

Triggers release pipeline does not contain core interceptors #1006

dibyom opened this issue Mar 18, 2021 · 0 comments · Fixed by #1007
Assignees
@dibyom
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@dibyom
Copy link
Member

dibyom commented Mar 18, 2021

Expected Behavior

The triggers release YAML should contain the core interceptor definitions + deployment YAMLs

Actual Behavior

Broken with #976

release.yaml will only contain the controller/webhook/eventlistener but not the core interceptors.

Additional Info

With #976, core interceptors are now installed as instances of the
ClusterInterceptor CRD. They are also bundled in a separate YAML file. We need
to wait for the Interceptors CRD to become established before we can create the
core interceptors. Otherwise, we run the risk of trying to create the
core-interceptors too early leading to installation errors. In #976 we fixed
the e2e install scripts to account for these changes but not the release
pipeline.
@dibyom dibyom added the kind/bug Categorizes issue or PR as related to a bug. label Mar 18, 2021
@dibyom dibyom self-assigned this Mar 18, 2021
dibyom added a commit to dibyom/triggers that referenced this issue Mar 18, 2021
@dibyom
Update publish task to include core interceptors
58a9938 
With tektoncd#976, core interceptors are now installed as instances of the
ClusterInterceptor CRD. They are also bundled in a separate YAML file. We need
to wait for the Interceptors CRD to become established before we can create the
core interceptors. Otherwise, we run the risk of trying to create the
core-interceptors too early leading to installation errors. In tektoncd#976 we fixed
the e2e install scripts to account for these changes but not the release
pipeline. This commit updates the release pipeline to add the new interceptors
YAML as part of the release assets.

Fixes tektoncd#1006

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@dibyom dibyom mentioned this issue Mar 18, 2021
Merged
4 tasks
tekton-robot pushed a commit that referenced this issue Mar 24, 2021
@dibyom @tekton-robot
Update publish task to include core interceptors
ce2fc7b 
With #976, core interceptors are now installed as instances of the
ClusterInterceptor CRD. They are also bundled in a separate YAML file. We need
to wait for the Interceptors CRD to become established before we can create the
core interceptors. Otherwise, we run the risk of trying to create the
core-interceptors too early leading to installation errors. In #976 we fixed
the e2e install scripts to account for these changes but not the release
pipeline. This commit updates the release pipeline to add the new interceptors
YAML as part of the release assets.

Fixes #1006

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@jmcshane jmcshane mentioned this issue Mar 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibyom dibyom

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update publish task to include core interceptors dibyom/triggers
1 participant
@dibyom