-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple from Pipeline or Align with Pipeline release #415
Comments
/area dependency |
The main usage of pipeline in triggers is the the |
For the 0.3 release, we decided that I can co-ordinate with CLI/Pipeline to ensure we have the pipeline version we need |
We can close this issue/readdress once we sync in 0.4. |
I agree with @vdemeester that it shouldn't be a problem to create our own Param types. Trying to create a quick summary, currently I think we use Pipelines for:
Is there anything else that I'm missing? |
I think that's about it |
I like Vincent's idea though I think this can wait till 0.5. |
/assign |
I found one other usage of Params (incl. ArrayParams): Header values in webhook interceptor. Though I'm wondering if we can always use []string like Go header values instead of arrayOrString. |
Another option is to use Go's http Header type. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Expected Behavior
Whenever a new pipeline is released, tkn-cli should have no problem in updating to it and at the same time using Triggers.
Actual Behavior
At present, this causes a dependency issue at tkn-cli side. We need to update Pipeline in Triggers before in tkn-cli.
Additional Info
Either decoupling or aligning Triggers with Pipeline release would solve this issue.
The text was updated successfully, but these errors were encountered: