Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple from Pipeline or Align with Pipeline release #415

Closed
khrm opened this issue Feb 5, 2020 · 15 comments
Closed

Decouple from Pipeline or Align with Pipeline release #415

khrm opened this issue Feb 5, 2020 · 15 comments
Assignees
Labels
area/dependency Issues or PRs related to dependency changes lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@khrm
Copy link
Contributor

khrm commented Feb 5, 2020

Expected Behavior

Whenever a new pipeline is released, tkn-cli should have no problem in updating to it and at the same time using Triggers.

Actual Behavior

At present, this causes a dependency issue at tkn-cli side. We need to update Pipeline in Triggers before in tkn-cli.

Additional Info

Either decoupling or aligning Triggers with Pipeline release would solve this issue.

@dibyom
Copy link
Member

dibyom commented Feb 5, 2020

/area dependency

@tekton-robot tekton-robot added the area/dependency Issues or PRs related to dependency changes label Feb 5, 2020
@dibyom dibyom added this to the Triggers 0.3 milestone Feb 5, 2020
@dibyom
Copy link
Member

dibyom commented Feb 5, 2020

The main usage of pipeline in triggers is the the Param type. Maybe we don't need to reuse param...I don't think we are using ArrayParams anyway!

@dibyom
Copy link
Member

dibyom commented Feb 18, 2020

For the 0.3 release, we decided that I can co-ordinate with CLI/Pipeline to ensure we have the pipeline version we need

@ncskier ncskier modified the milestones: Triggers 0.3, Triggers v0.4.0 Feb 21, 2020
@vtereso
Copy link

vtereso commented Mar 24, 2020

We can close this issue/readdress once we sync in 0.4.

@vdemeester
Copy link
Member

@vtereso how so ? this will be an issue after 0.4 right ?
@dibyom if it's only for Param types, it might be worth "duplicating" those (acting like a completely separate client, using the API only, no shared code)

@ncskier
Copy link
Member

ncskier commented Mar 24, 2020

@dibyom if it's only for Param types, it might be worth "duplicating" those (acting like a completely separate client, using the API only, no shared code)

I agree with @vdemeester that it shouldn't be a problem to create our own Param types.


Trying to create a quick summary, currently I think we use Pipelines for:

  • tests
  • Params
  • clientset for creating resources (the two files mentioned in this issue)

Is there anything else that I'm missing?

@dibyom
Copy link
Member

dibyom commented Mar 30, 2020

I think that's about it

@dibyom
Copy link
Member

dibyom commented Mar 31, 2020

I like Vincent's idea though I think this can wait till 0.5.

@dibyom
Copy link
Member

dibyom commented Apr 7, 2020

/assign

@dibyom
Copy link
Member

dibyom commented Apr 24, 2020

I found one other usage of Params (incl. ArrayParams): Header values in webhook interceptor. Though I'm wondering if we can always use []string like Go header values instead of arrayOrString.

@ncskier
Copy link
Member

ncskier commented Apr 28, 2020

Another option is to use Go's http Header type.
Although, that's a map[string][]string, so it would change the interceptor YAML syntax a bit.

@dibyom dibyom removed this from the Triggers v0.7.0 milestone Jul 28, 2020
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 26, 2020
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 25, 2020
@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 25, 2020
@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants