CLI tool for manual Trigger runs #624

dibyom · 2020-06-19T15:42:33Z

Expected Behavior

I can easily test out their Trigger config e.g. does the CEL expression work, does my binding expression extract the right variable, does my trigger template replace the right variable etc.

Actual Behavior

I have to setup an EventListener, TriggerBinding, and TriggerTemplate. I have to port-forward to the Listener, and make a curl call, and then look into the Listener logs to figure out what happened.

Additional Info

Example CLI surface from discussing with @bigkevmcd :

triggers-run -H "X-GitHub-Event: testing" -d @testing.json -f triggers.yaml

triggers.yaml is a file containing the trigger definitions
The CLI supports curl like flags for sending headers and body
The tool will prints out the trigger processing logs to stdout
It will also print out the fully formed Tekton resource to be created once the trigger is processed instead of creating them

Out of scope for now:

Testing Trigger level service account permissions

Can be added later:

Actually create the resources instead of just printing them out
Dry run against a already running listener instead of definitions from a file
Make it part of the tkn surface e.g. tkn trigger run ....
Account for the Trigger service account permissions

TriggerTemplateRun TriggerTemplateRun !? #200
Binding eval tool FR: Binding resolution utility #314

/kind feature

The text was updated successfully, but these errors were encountered:

dibyom · 2020-06-19T15:43:45Z

/cc @wlynch @dorismeixing @bigkevmcd

vdemeester · 2020-06-22T14:44:44Z

Any reason for not pushing for having this in tkn early ? 🤔
/cc @danielhelfand @pradeepitm12 @piyush-garg

danielhelfand · 2020-06-22T16:18:05Z

Any reason for not pushing for having this in tkn early ? 🤔

Reading this, it sounds like more of a proof of concept/basic requirements at this point and could potentially be added to tkn later on (e.g. tkn trigger run under Can be added later) if understanding correctly? Either as part of tkn itself or maybe could be added as some type of plugin to tkn if that would be a more preferred route.

But I would see no reason not to want something like this as part of tkn. Just would maybe need some thought on where it would best fit structurally.

dibyom · 2020-06-22T18:55:56Z

yeah, one motivation for keeping this in Triggers would be faster/easier iteration -- we'd have to do some refactoring to how we execute a Trigger to ensure we can run it outside the context of an EventListener. Once that is done, it should be easy enough to make it part of the tkn surface!
(The plugin model sounds cool too!!)

This part one contians the funcstions to parse yaml file and HTTP, and the corresponding unit test. It relates to issue tektoncd#624.

This part one contians the funcstions to parse yaml file and HTTP, and the corresponding unit test. It relates to issue #624.

The existing `resolveTrigger` and related Trigger processing functions currently assume an `EventListenerTrigger` input. With the introduction of Trigger CRDs, we need a mechanism to handle triggers consisently, regardless of their originating type. As a first step, this allows for `TriggerSpec` to be converted to `EventListenerTrigger` in order to reuse existing libraries. Part of the work required for tektoncd#624.

The existing `resolveTrigger` and related Trigger processing functions currently assume an `EventListenerTrigger` input. With the introduction of Trigger CRDs, we need a mechanism to handle triggers consisently, regardless of their originating type. As a first step, this allows for `TriggerSpec` to be converted to `EventListenerTrigger` in order to reuse existing libraries. Part of the work required for #624.

…l referenced bindings, find the trigger template, apply the HTTP request to the binding and template the part for ProcessTriggerSpec Add the part one of CLI for trigger run. This part one contians the funcstions to parse yaml file and HTTP, and the corresponding unit test. It relates to issue tektoncd#624. Add unit test for processTriggerSpec Add unit test for processTriggerSpec Add ProcessTriggerSpec function to take a Triggers.yaml file, find all referenced bindings, find the trigger template, apply the HTTP request to the binding and template Add unit test for processTriggerSpec

This part one contians the funcstions to parse yaml file and HTTP, and the corresponding unit test. It relates to issue tektoncd#624.

tekton-robot · 2020-08-14T23:46:14Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot · 2020-08-14T23:46:14Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

tekton-robot · 2020-08-14T23:46:16Z

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dibyom · 2020-08-18T21:07:49Z

We have some experimental code for this that processes Triggers locally. We should do a release for it and then figure out if it makes sense to merge that into the CLI

tekton-robot · 2020-11-16T21:55:10Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

vdemeester · 2020-11-17T08:50:17Z

/remove-lifecycle stale

tekton-robot · 2021-02-15T09:50:08Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot · 2021-03-17T10:17:13Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

dibyom · 2021-03-17T14:40:55Z

/remove-lifecycle rotten

tekton-robot · 2021-06-15T14:51:39Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot · 2021-10-14T22:07:29Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot · 2021-11-13T23:01:27Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot · 2021-11-13T23:01:29Z

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 19, 2020

dorismeixing added a commit to dorismeixing/triggers that referenced this issue Jul 9, 2020

Add the part one of CLI for trigger run.

7d921c8

This part one contians the funcstions to parse yaml file and HTTP, and the corresponding unit test. It relates to issue tektoncd#624.

tekton-robot pushed a commit that referenced this issue Jul 10, 2020

Add the part one of CLI for trigger run.

2fa3323

This part one contians the funcstions to parse yaml file and HTTP, and the corresponding unit test. It relates to issue #624.

dorismeixing mentioned this issue Jul 14, 2020

Add a new CRD type called Trigger #628

Merged

3 tasks

wlynch mentioned this issue Jul 14, 2020

Add ToEventListenerTrigger conversion func. #676

Merged

2 tasks

dorismeixing added a commit to dorismeixing/triggers that referenced this issue Jul 22, 2020

Add the part one of CLI for trigger run.

ff4a7a8

This part one contians the funcstions to parse yaml file and HTTP, and the corresponding unit test. It relates to issue tektoncd#624.

dorismeixing mentioned this issue Jul 27, 2020

Add processTriggerSpec func to wire it to Trigger, and the corresponding unit test #686

Merged

3 tasks

dorismeixing mentioned this issue Aug 4, 2020

Add interceptor to processTriggerSpec, update readHTTP and trigger function #695

Merged

3 tasks

dorismeixing mentioned this issue Aug 11, 2020

Add createResource in TriggerRun CLI #708

Merged

3 tasks

tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 14, 2020

tekton-robot closed this as completed Aug 14, 2020

dibyom reopened this Aug 18, 2020

dibyom removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 18, 2020

tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 16, 2020

tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2020

tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2021

tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 17, 2021

tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 17, 2021

tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 15, 2021

tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 14, 2021

tekton-robot closed this as completed Nov 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLI tool for manual Trigger runs #624

CLI tool for manual Trigger runs #624

dibyom commented Jun 19, 2020 •

edited

Loading

dibyom commented Jun 19, 2020

vdemeester commented Jun 22, 2020

danielhelfand commented Jun 22, 2020

dibyom commented Jun 22, 2020

tekton-robot commented Aug 14, 2020

tekton-robot commented Aug 14, 2020

tekton-robot commented Aug 14, 2020

dibyom commented Aug 18, 2020

tekton-robot commented Nov 16, 2020

vdemeester commented Nov 17, 2020

tekton-robot commented Feb 15, 2021

tekton-robot commented Mar 17, 2021

dibyom commented Mar 17, 2021

tekton-robot commented Jun 15, 2021

tekton-robot commented Oct 14, 2021

tekton-robot commented Nov 13, 2021

tekton-robot commented Nov 13, 2021

CLI tool for manual Trigger runs #624

CLI tool for manual Trigger runs #624

Comments

dibyom commented Jun 19, 2020 • edited Loading

Expected Behavior

Actual Behavior

Additional Info

dibyom commented Jun 19, 2020

vdemeester commented Jun 22, 2020

danielhelfand commented Jun 22, 2020

dibyom commented Jun 22, 2020

tekton-robot commented Aug 14, 2020

tekton-robot commented Aug 14, 2020

tekton-robot commented Aug 14, 2020

dibyom commented Aug 18, 2020

tekton-robot commented Nov 16, 2020

vdemeester commented Nov 17, 2020

tekton-robot commented Feb 15, 2021

tekton-robot commented Mar 17, 2021

dibyom commented Mar 17, 2021

tekton-robot commented Jun 15, 2021

tekton-robot commented Oct 14, 2021

tekton-robot commented Nov 13, 2021

tekton-robot commented Nov 13, 2021

dibyom commented Jun 19, 2020 •

edited

Loading